-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/avahi: Enable IPv6 by default #361016
Conversation
Does anyone know why the options IMO the whole point of enabling avahi is being able to resolve *.local domains and being resolveable as well. The currently required configuration to do that is big:
On other distributions like arch this just works™ |
@frederictobiasc I agree that these options should probably also be turned on for a better user experience. Avahi is also being used to announce and discover the presence of services on the network via dbus. For instance, pipewire/pulseaudio is able to detect other instances/sinks over the network and make them available automatically. The nss module is not needed for this to work. |
We also have to add release notes if we change the defaults. |
@fpletz But do you support enabling nss modules by default as well? I'll update the PR accordingly. |
I just discovered #258424 where IPv6 was explicitly disabled. This doesn't make sense and IMHO shouldn't have been done on that PR. @SuperSandro2000 Since it wasn't mentioned in that PR, do you recall the reasoning behind disabling IPv6?
I would prefer another PR since IPv6 support itself should be less controversial. |
eabd388
to
2918b64
Compare
2918b64
to
35a0ec8
Compare
Done!
I opened #361191 for that. |
35a0ec8
to
a2857d8
Compare
It is super controversial and should stay turned off.
I don't think anything has changed about this, or has it? If not this should absolutely stay turned off otherwise most people will wait long timeouts for no reason. |
@SuperSandro2000 But as far as I understand the problem is NSS and not IPv6 support per se in Avahi, right? That's why I was advocating to split NSS into a different PR. IPv6 support shouldn't trigger the problem you encountered when only I would personally love to have IPv6 support enabled for all applications we ship by default. |
oh, true, not sure how this could be related or not to avahi itself 🤔 |
Ok so it's fine to merge this now and continue the discussion regarding nss in #361191, correct? |
a2857d8
to
5aae70e
Compare
Avahi's default for `use-ipv6` is yes as well. I see no reason why we should do this differently.
5aae70e
to
07e283f
Compare
Avahi's default for
use-ipv6
is yes as well. I see no reason why we should do this differently.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.