Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: 38.105.2 -> 39.42.4 #361090

Merged
merged 1 commit into from
Dec 10, 2024
Merged

renovate: 38.105.2 -> 39.42.4 #361090

merged 1 commit into from
Dec 10, 2024

Conversation

NyCodeGHG
Copy link
Member

https://docs.renovatebot.com/release-notes-for-major-versions/#version-39
https://github.com/renovatebot/renovate/releases/tag/39.0.0
supersedes #360901

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 2, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 6, 2024
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@ofborg ofborg bot requested a review from natsukium December 10, 2024 08:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 labels Dec 10, 2024
Upgrades to renovate major version 39.
Like upstream, we also upgrade renovate's nodejs version to 22.
Renovate checks for a specific nodejs version at runtime,
so we relax that a bit. Otherwise it would log an error
everytime it is run with an older (minor/patch) version.
@Scrumplex Scrumplex added the backport release-24.11 Backport PR automatically label Dec 10, 2024
@NyCodeGHG
Copy link
Member Author

@Scrumplex I don't think we should backport this, it's a major version upgrade and contains (very few, but still) breaking changes.

@Scrumplex
Copy link
Member

Oh, I went through my open tabs and added the label to a few of them. I didn't mean to add it here ^^

@Scrumplex Scrumplex removed the backport release-24.11 Backport PR automatically label Dec 10, 2024
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

nixos/tests/renovate.nix Outdated Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 361090


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • renovate

aarch64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • renovate

x86_64-darwin

✅ 1 package built:
  • renovate

aarch64-darwin

✅ 1 package built:
  • renovate

@Scrumplex
Copy link
Member

@ofborg test renovate

@Scrumplex Scrumplex merged commit 75d54b4 into NixOS:master Dec 10, 2024
22 of 25 checks passed
@NyCodeGHG NyCodeGHG deleted the renovate-v39 branch December 10, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants