Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.expo-cli: drop #361284

Merged
merged 1 commit into from
Dec 8, 2024
Merged

nodePackages.expo-cli: drop #361284

merged 1 commit into from
Dec 8, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Dec 3, 2024

expo-cli is deprecated upstream, see https://www.npmjs.com/package/expo-cli and https://blog.expo.dev/the-new-expo-cli-f4250d8e342.

part of #229475

closes #349434 as the package is being dropped

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 3, 2024
@pyrox0 pyrox0 force-pushed the node-drop/expo-cli branch from 98486c7 to d53a132 Compare December 3, 2024 01:11
@pyrox0 pyrox0 requested a review from getchoo December 3, 2024 07:37
@pyrox0 pyrox0 force-pushed the node-drop/expo-cli branch from d53a132 to 622f3b0 Compare December 4, 2024 01:04
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Dec 4, 2024
@pyrox0 pyrox0 self-assigned this Dec 4, 2024
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@tomodachi94 tomodachi94 added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 6, 2024
expo-cli is deprecated upstream
@pyrox0 pyrox0 force-pushed the node-drop/expo-cli branch from 622f3b0 to bb22d69 Compare December 8, 2024 20:57
@pyrox0
Copy link
Member Author

pyrox0 commented Dec 8, 2024

This kinda slipped through the cracks for a bit. resolved the merge conflicts!

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 8, 2024
@getchoo getchoo removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 8, 2024
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 8, 2024
@getchoo getchoo merged commit 25fe86d into NixOS:master Dec 8, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
Status: Dropped
4 participants