Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.insect: drop #361287

Merged
merged 1 commit into from
Dec 5, 2024
Merged

nodePackages.insect: drop #361287

merged 1 commit into from
Dec 5, 2024

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Dec 3, 2024 •
edited
Loading

per https://github.com/sharkdp/insect?tab=readme-ov-file#note-please-consider-using-the-follow-up-project-instead-numbat, numbat(packaged as pkgs.numbat) should be used instead, and insect is deprecated.

part of #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 3, 2024
@pyrox0 pyrox0 requested a review from getchoo December 3, 2024 07:36
@getchoo getchoo mentioned this pull request Dec 3, 2024
Merged
13 tasks
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Dec 4, 2024
@pyrox0 pyrox0 self-assigned this Dec 4, 2024
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 4, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 4, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2024
tomodachi94
tomodachi94 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good to me. Could you rebase this onto master and resolve the merge conflict?

@tomodachi94 tomodachi94 added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 5, 2024
@pyrox0
Copy link
Member Author

pyrox0 commented Dec 5, 2024

The diff looks good to me. Could you rebase this onto master and resolve the merge conflict?

Done!

@tomodachi94
Copy link
Member

Result of nixpkgs-review pr 361287 run on aarch64-linux 1

1 package blacklisted:
  • nixos-install-tools

tomodachi94
tomodachi94 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@tomodachi94 tomodachi94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm heading to bed; I'll take a look at your remaining nodePackages sometime tomorrow. 💖

@tomodachi94 tomodachi94 merged commit 28aad69 into NixOS:master Dec 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomodachi94 tomodachi94 tomodachi94 approved these changes

@getchoo getchoo getchoo approved these changes

Assignees

@pyrox0 pyrox0

Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: nodejs 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
Repackage node2nix packages
Status: Dropped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pyrox0 @tomodachi94 @getchoo @wegank