nixos/exwm: fix services.xserver.windowManager.exwm.enable option #361714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
|
Needs backport to 24.11 because this is broken in NixOS 24.11 |
github-actions
bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12. first-time contribution
stanleyj-edsn
changed the title
thiagokokada
reviewed
Dec 4, 2024
thiagokokada
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Code wise looks good, but please squash your commits accordingly to the CONTRIBUTING.md guidelines. You should have only one commit similar to:
nixos/exwm: remove services.xserver.windowManager.exwm.enableDefaultConfig
Fix error: 'emacsWithPackages' has been renamed to/replaced by 'emacs.pkgs.withPackages' Fix: NixOS#361706
stanleyj-edsn
force-pushed
the
fix-window-manager-exwm
branch
from
501892e to
1351ea6
Compare
thiagokokada
approved these changes
Dec 4, 2024
The default configuration was removed from upstream, see emacs-exwm/exwm#57 Fix: NixOS#319541 Co-authored-by: Lin Jian <[email protected]>
jian-lin
force-pushed
the
fix-window-manager-exwm
branch
from
1351ea6 to
c82bf95
Compare
|
I took the liberty to remove the mention of |
jian-lin
added
backport release-24.11
|
I also changed the backport label from |
Merged
1 task
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #319541
Fix: #361706
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.