-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oscar: add Darwin support #361956
base: master
Are you sure you want to change the base?
oscar: add Darwin support #361956
Conversation
8b39a8f
to
41ce33d
Compare
if stdenv.isDarwin then | ||
'' | ||
install -d $out/Applications | ||
mv oscar/OSCAR.app $out/Applications |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also link executable to $out/bin
and test if it works. (otherwise mainProgram
becomes invalid)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a macOS perspective this seems like an unusual thing to do, and it would make more sense to me to remove the mainProgram
attribute on Darwin. I haven't really been keeping up with nixpkgs lately, so if that's the convention then I don't mind doing so. The one thing I found when searching (mainProgram
for Mac OS Apps) made it seem like macOS wasn't really considered when implementing the mainProgram feature, and also didn't arrive at a conclusion for what to do in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very sure about that, but I got a request at #360354 (comment). As it doesn't hurt anything and it ease test when reviewing new versions, I'd suggest to add it as well.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.