nixos/zfs: skip scrub if one is in progress #362131
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zpool-scrub` command has only one non-zero return code and that is for everything: failed to initiate a scrub for _some_ reason, but not for which reason. Since that doesn't exist, we can check the output of the `zpool-status` command and see if a scrub is in progress. If it is, we skip scrubbing the zpool because doing so would do nothing but cause the `zpool-scrub` command to erroneously exit. A `for` loop was added to iterate over multiple zpools, in case there are more than one zpool that the user hasn't specified in the NixOS configuration. Fixes NixOS#361952.
github-actions
bot
added
6.topic: nixos
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4924 |
|
Checking if something can be done and then doing the thing is prone to race-conditions. Instead of first checking if a scrub is not running and then starting the scrub, is it instead possible to try to start the scrub and if that fails to analyze the error message to determine if it failed due to a scrub already running? |
|
That's actually a better approach. I started a scrub and attempting to start a scrub while one is in progress, I get the following error message: I'll push another commit soon-ish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zpool-scrubcommand has only one non-zero return code and that is for everything: failed to initiate a scrub for some reason, but not for which reason. Since that doesn't exist, we can check the output of thezpool-statuscommand and see if a scrub is in progress. If it is, we skip scrubbing the zpool because doing so would do nothing but cause thezpool-scrubcommand to erroneously exit.A
forloop was added to iterate over multiple zpools, in case there are more than one zpool that the user hasn't specified in the NixOS configuration.Fixes #361952.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.