Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.azure-multiapi-storage: fix build #362147

Merged

Conversation

pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Dec 5, 2024

Removes the unused msrestazure dependency and adds the missing python-dateutil dependency, as well as some slight changes to modernize it.

part of #350657

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Removes the unused msrestazure dependency and adds the missing
python-dateutil dependency

Removes the unused msrestazure dependency and adds the missing
python-dateutil dependency
@philiptaron
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 362147


x86_64-linux

✅ 6 packages built:
  • azure-cli
  • azure-cli.dist
  • python311Packages.azure-multiapi-storage
  • python311Packages.azure-multiapi-storage.dist
  • python312Packages.azure-multiapi-storage
  • python312Packages.azure-multiapi-storage.dist

@philiptaron philiptaron merged commit 6dc317f into NixOS:master Dec 5, 2024
19 of 20 checks passed
@pyrox0 pyrox0 added the backport release-24.11 Backport PR automatically label Dec 5, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 5, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants