buildBazelPackage: use same bazel for deps & build #362195
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should make more sense to use same `bazel` to produce & consume the deps. Produced deps tarball seems to be currently the same if build with or without `enableNixHacks`, at least have verified it for `fcitx5-mozc`. Since we also start using `bazelForBuild.name` for version string it will invalidate the deps, which sounds like a good thing to do on `buildBazelPackage` changes. This will cause a rebuild but relatively few packages are affected.
This comment was marked as outdated.
This comment was marked as outdated.
boltzmannrain
force-pushed
the
build_bazel_package_bazel
branch
from
9aacdc5 to
5cfb1cf
Compare
This comment was marked as outdated.
This comment was marked as outdated.
boltzmannrain
force-pushed
the
build_bazel_package_bazel
branch
from
5cfb1cf to
f89e75e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Marking this as draft while it's still a work in progress. Ping me when it's ready for review. |
boltzmannrain
force-pushed
the
build_bazel_package_bazel
branch
from
f89e75e to
6022f67
Compare
|
@ofborg build bant |
github-actions
bot
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin: 1-10
labels
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should make more sense to use same
bazelto produce & consume the deps.Produced deps tarball seems to be currently the same if build
with or without
enableNixHacks, at least have verified it forfcitx5-mozc.Since we also start using
bazelForBuild.namefor version string itwill invalidate the deps, which sounds like a good thing to do on
buildBazelPackagechanges. This will cause a rebuild but relativelyfew packages are affected.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.