Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] fsautocomplete: 0.73.2 -> 0.75.0 #364736

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

nixpkgs-ci[bot]
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Dec 12, 2024

Bot-based backport to release-24.11, triggered by a label in #360986.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

(cherry picked from commit 44c6cc4)
@corngood
Copy link
Contributor

@gbtb @kalekseev do you think this is suitable to backport?

@kalekseev
Copy link
Contributor

@gbtb @kalekseev do you think this is suitable to backport?

I think, yes if sdk6, sdk7 were removed in 24.11 release otherwise need to research implication.

@corngood
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 364736


x86_64-linux

✅ 1 package built:
  • fsautocomplete

@gbtb
Copy link
Member

gbtb commented Dec 13, 2024

I think it's fine to backport.

@corngood
Copy link
Contributor

I think, yes if sdk6, sdk7 were removed in 24.11 release otherwise need to research implication.

not removed, but they are marked insecure, so we've generally been backporting things that remove the insecure dependencies.

I would generally consider 0.x version upgrades to be okay to backport. I just wanted to check.

@corngood corngood merged commit 1f218d4 into release-24.11 Dec 13, 2024
35 of 38 checks passed
@corngood corngood deleted the backport-360986-to-release-24.11 branch December 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants