Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awsume: propagate setuptools build input #364972

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Dec 13, 2024

Fixes #364969

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The failing command now works:

$ awsume-configure
===== Setting up bash =====
Wrote alias to /Users/acotten/.bash_profile
Wrote autocomplete script to /Users/acotten/.bash_profile
===== Setting up zsh =====
Wrote alias to /Users/acotten/.zshenv
Wrote autocomplete script to /Users/acotten/.zshenv
Wrote zsh function to /Users/acotten/.awsume/zsh-autocomplete/_awsume
===== Finished setting up =====

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 13, 2024
@antoineco
Copy link
Contributor Author

I think it would be valuable to backport this to nixos-24.11 and nixos-24.05 since both are affected.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 15, 2024
@Aleksanaa Aleksanaa merged commit 3e2af6b into NixOS:master Dec 15, 2024
52 of 53 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Git push to origin failed for release-24.05 with exitcode 1

1 similar comment
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Git push to origin failed for release-24.05 with exitcode 1

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Successfully created backport PR for release-24.05:

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Git push to origin failed for release-24.11 with exitcode 1

1 similar comment
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Git push to origin failed for release-24.11 with exitcode 1

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 15, 2024

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle! backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awsume is missing 'setuptools' dependency
5 participants