Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ask-mai: init at 0.7.0 #365024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ask-mai: init at 0.7.0 #365024

wants to merge 1 commit into from
+106 −0

Conversation

confusedalex
Copy link
Contributor

inits ask-mai at version 0.2.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 13, 2024
steeleduncan
steeleduncan suggested changes Dec 13, 2024
View reviewed changes
pkgs/by-name/as/ask-mai/package.nix Outdated Show resolved Hide resolved
steeleduncan
steeleduncan reviewed Dec 14, 2024
View reviewed changes
Copy link
Contributor

@steeleduncan steeleduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a maintainer of any node packages, so I don't think it is appropriate for me to leave an approving review, but thanks for making that change, looks good to me!

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 14, 2024
@confusedalex confusedalex force-pushed the init-ask-mai branch 2 times, most recently from b31fb75 to 6791d46 Compare December 15, 2024 10:53
@confusedalex confusedalex changed the title ask-mai: init at 0.2.0 ask-mai: init at 0.2.1 Dec 15, 2024
@confusedalex confusedalex force-pushed the init-ask-mai branch 2 times, most recently from b4c7335 to 7e60395 Compare December 26, 2024 13:55
@confusedalex confusedalex changed the title ask-mai: init at 0.2.1 ask-mai: init at 0.4.0 Dec 26, 2024
@confusedalex confusedalex changed the title ask-mai: init at 0.4.0 ask-mai: init at 0.6.1 Jan 3, 2025
@confusedalex confusedalex changed the title ask-mai: init at 0.6.1 ask-mai: init at 0.7.0 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steeleduncan steeleduncan steeleduncan requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@confusedalex @steeleduncan