Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/archtika: init at 1.0.1 #365218

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

nixos/archtika: init at 1.0.1 #365218

wants to merge 4 commits into from
+393 −0

Conversation

thiloho
Copy link

@thiloho thiloho commented Dec 14, 2024 •
edited
Loading

This PR adds the archtika package and its NixOS module.

archtika is a modern Content Management System (CMS) designed for the creation and management of documentation and blog websites. It focuses on simplicity, performance and maintainability, while providing essential features for content creators, such as:

  • Easy website creation with predefined templates
  • Markdown support with live preview
  • Collaboration features
  • Storage management
  • Change tracking
  • Automatic static site generation

Homepage: https://archtika.com
Repository: https://github.com/archtika/archtika

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Dec 14, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 14, 2024
@thiloho
Copy link
Author

thiloho commented Dec 14, 2024

Some improvements can be made, such as avoiding the with expressions (https://nix.dev/guides/best-practices#with-scopes), possibly using recursiveUpdate (https://nix.dev/guides/best-practices#updating-nested-attribute-sets) and other nitpicks.

I will look into this.

SigmaSquadron
SigmaSquadron reviewed Dec 14, 2024
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always great to see someone's first contribution is a massive NixOS module. Great work on this!

The following commits should be squashed:

  • archtika: fix allow-import-from-derivation error for npm ➜ archtika: init at 1.0.1
  • nixos/manual: add archtika module to 25.05 release notes ➜ nixos/archtika: init module
  • archtika: fix formatting, add module description, remove trailing whitespace and archtika: refactor package and module definitions ➜ Both the package and module commit, as appropriate.

nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/archtika/package.nix Show resolved Hide resolved
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 15, 2024
@thiloho thiloho force-pushed the archtika-pkg branch 3 times, most recently from c30931a to 855e916 Compare December 25, 2024 18:47
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2167

@thiloho
Copy link
Author

thiloho commented Dec 26, 2024

Hi @Lassulus , seeing that you recently merged another pull request (#365006), could you please check this one? As far as I can see it should be ready.

SuperSandro2000
SuperSandro2000 reviewed Jan 3, 2025
View reviewed changes
pkgs/by-name/ar/archtika/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/archtika/package.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
nixos/modules/services/web-apps/archtika.nix Outdated Show resolved Hide resolved
@thiloho
Copy link
Author

thiloho commented Jan 7, 2025 •
edited
Loading

I have also tested all the functionality again using the given steps and using a local setup in the repository, see https://github.com/archtika/archtika/blob/main/nix/module.nix

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2188

@thiloho
archtika: init at 1.0.1
eacab79 
archtika: fix allow-import-from-derivation error for npm

archtika: fix package formatting

archtika: refactor package

archtika: update GitHub hash for version 1.0.1

archtika: add auto update script

archtika: refactor package

archtika: update version to 1.1.0

archtika: update GitHub hash to version 1.1.0
@thiloho
nixos/archtika: init module
12610f3 
nixos/manual: add archtika module to 25.05 release notes

nixos/archtika: fix module formatting, add description and remove trailing whitespace

nixos/archtika: refactor module

nixos/archtika: refactor module

nixos/archtika: make SystemCallFilter addition for postgres systemd service
@thiloho
maintainers: add thiloho
c62e620
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thiloho @nixos-discourse @SuperSandro2000 @SigmaSquadron @h7x4 @NixOSInfra