Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libretro: fix build with GCC 14 #368955

Merged
merged 5 commits into from
Dec 29, 2024
Merged

libretro: fix build with GCC 14 #368955

merged 5 commits into from
Dec 29, 2024

Conversation

thiagokokada
Copy link
Contributor

Fix retroarch-full.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@thiagokokada
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368955

x86_64-linux

✅ 6 packages built:
  • libretro.fbalpha2012
  • libretro.mame2003
  • libretro.mame2016
  • libretro.np2kai
  • retroarch-free
  • retroarch-full

paparodeo
paparodeo reviewed Dec 29, 2024
View reviewed changes
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like, at least for the 2 I tried, that rather than pinning to gcc13 can add env.NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-pointer-types"; instead. still not great but slightly better than pinning to an old compiler / toolchain.

@thiagokokada thiagokokada changed the title libretro: use gcc13Stdenv for some cores libretro: fix build for GCC 14 Dec 29, 2024
@thiagokokada
Copy link
Contributor Author

it looks like, at least for the 2 I tried, that rather than pinning to gcc13 can add env.NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-pointer-types"; instead. still not great but slightly better than pinning to an old compiler / toolchain.

Done, now np2kai and mame2003 are building with GCC 14.

The only one that is kept in GCC 13 is mame2016, that build failures are not related to compilation but link failures.

@thiagokokada thiagokokada changed the title libretro: fix build for GCC 14 libretro: fix build with GCC 14 Dec 29, 2024
paparodeo
paparodeo approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagokokada
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368955

x86_64-linux

✅ 6 packages built:
  • libretro.fbalpha2012
  • libretro.mame2003
  • libretro.mame2016
  • libretro.np2kai
  • retroarch-free
  • retroarch-full

@thiagokokada thiagokokada merged commit 6d37130 into NixOS:master Dec 29, 2024
23 of 24 checks passed
@thiagokokada thiagokokada deleted the retroarch-fixes branch December 29, 2024 13:14
@wegank wegank mentioned this pull request Dec 31, 2024
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paparodeo paparodeo paparodeo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thiagokokada @paparodeo