Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cudaPackages.nccl-tests: 2.13.11 -> 2.13.12 #370646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 3, 2025

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

  • WARNING: Package has meta.broken=true; Please manually test this package update and remove the broken attribute.

meta.description for cudaPackages.nccl-tests is: Tests to check both the performance and the correctness of NVIDIA NCCL operations

meta.homepage for cudaPackages.nccl-tests is: https://github.com/NVIDIA/nccl-tests

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 2.13.12 in filename of file in /nix/store/qgrmn7447sav12jy09vphcr0lnvkqxxk-nccl-tests-2.13.12

Rebuild report (if merged into master) (click to expand)
3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

cudaPackages.nccl-tests
cudaPackages_11.nccl-tests
Instructions to test this update (click to expand)

Either download from the cache:

nix-store -r /nix/store/qgrmn7447sav12jy09vphcr0lnvkqxxk-nccl-tests-2.13.12 \
  --option binary-caches 'https://cache.nixos.org/ https://nixpkgs-update-cache.nix-community.org/' \
  --option trusted-public-keys '
  nixpkgs-update-cache.nix-community.org-1:U8d6wiQecHUPJFSqHN9GSSmNkmdiFW7GW7WNAnHW0SM=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The nixpkgs-update cache is only trusted for this store-path realization.)
For the cached download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cudaPackages.nccl-tests https://github.com/r-ryantm/nixpkgs/archive/af9a2f63cf1efc6444fe9d76f165283e86cb4110.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/af9a2f63cf1efc6444fe9d76f165283e86cb4110#cudaPackages.nccl-tests

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/qgrmn7447sav12jy09vphcr0lnvkqxxk-nccl-tests-2.13.12
ls -la /nix/store/qgrmn7447sav12jy09vphcr0lnvkqxxk-nccl-tests-2.13.12/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • cudaPackages.nccl-tests
  • cudaPackages_11.nccl-tests

Maintainer pings

cc @jmillerpdt @ConnorBaker @samuela @SomeoneSerge for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 3, 2025
@samuela
Copy link
Member

samuela commented Jan 9, 2025

broken = !config.cudaSupport || (mpiSupport && mpi == null);

so i think the broken warning is a false alarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cuda Parallel computing platform and API 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants