Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arti: cleanup #372740

Merged
merged 1 commit into from
Jan 10, 2025
Merged

arti: cleanup #372740

merged 1 commit into from
Jan 10, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 10, 2025 •
edited
Loading

Things done

  • remove useless darwin dependency
  • switch to tag for fetchFromGitLab
  • add versionChechHook
  • add passthru.updateScript

cc @Steinhagen

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
arti: cleanup
cda2820 
- remove useless darwin dependency
- switch to tag for fetchFromGitLab
- add versionChechHook
- add passthru.updateScript
@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372740

x86_64-linux

✅ 1 package built:
  • arti

aarch64-linux

✅ 1 package built:
  • arti

x86_64-darwin

✅ 1 package built:
  • arti

aarch64-darwin

✅ 1 package built:
  • arti

@GaetanLepage GaetanLepage merged commit 273027d into NixOS:master Jan 10, 2025
70 checks passed
@GaetanLepage GaetanLepage deleted the arti branch January 10, 2025 21:26
@Eveeifyeve
Copy link
Contributor

Is there going to be a backport soon of arti?

@GaetanLepage
Copy link
Contributor Author

Is there going to be a backport soon of arti?

arti is already available on nixos-24.11. What do you mean by "backport" ?

@Eveeifyeve
Copy link
Contributor

Eveeifyeve commented Jan 12, 2025 •
edited
Loading

Is there going to be a backport soon of arti?

arti is already available on nixos-24.11. What do you mean by "backport" ?

Yes, but it hasn't been updated since 1.2 and the latest is 1.3. What I mean is there going to be manual backport to update arti?

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Jan 12, 2025 •
edited
Loading

Is there going to be a backport soon of arti?

arti is already available on nixos-24.11. What do you mean by "backport" ?

Yes, but it hasn't been updated since 1.2 and the latest is 1.3. What I mean is there going to be manual backport to update arti?

Unfortunately, we can't backport breaking changes. See #352881 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drupol drupol drupol approved these changes

@Steinhagen Steinhagen Awaiting requested review from Steinhagen

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GaetanLepage @Eveeifyeve @drupol