Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esphome: 2024.12.2 -> 2024.12.4 #374675

Merged
merged 1 commit into from
Jan 18, 2025
Merged

esphome: 2024.12.2 -> 2024.12.4 #374675

merged 1 commit into from
Jan 18, 2025
+2 −2

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 17, 2025 •
edited
Loading

https://github.com/esphome/esphome/releases/tag/2024.12.3 https://github.com/esphome/esphome/releases/tag/2024.12.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from globin January 17, 2025 23:52
@momeemt
Copy link
Member

momeemt commented Jan 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374675

aarch64-darwin

✅ 2 packages built:
  • esphome
  • esphome.dist

@NickCao NickCao merged commit 0ad23d2 into NixOS:master Jan 18, 2025
25 of 27 checks passed
dustypomerleau pushed a commit to dustypomerleau/nixpkgs that referenced this pull request Jan 20, 2025
@NickCao @dustypomerleau
esphome: 2024.12.2 -> 2024.12.4 (NixOS#374675)
431f009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momeemt momeemt momeemt approved these changes

@NickCao NickCao NickCao approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @momeemt @NickCao