Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: Fix compilation to 32-bit ARM with clang in downstream packages #375322

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

yuyuyureka
Copy link
Contributor

It is not a fetchpatch because of how the various subcomponents get integrated into the boost source tarball.
The --replace-fail should be sufficient to stop this from rotting after future updates.

Change-Id: I5b4e4e3f43a3360d987bfe34cb24cc60ce3b5957

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Change-Id: I4eafd2adc9dbd2387e298829fe635dd667ab6ce4
@yuyuyureka yuyuyureka merged commit 56b1e1c into NixOS:staging Jan 21, 2025
35 of 39 checks passed
@yuyuyureka yuyuyureka deleted the boost-armv7l-clang branch January 21, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants