softether: build fix

[Nobody-alias-N]

Resolves #375419

ref. #356812

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Nobody-alias-N]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375656

---

x86_64-linux

✅ 1 package built:

• softether

[Nobody-alias-N]

@FliegendeWurst
I want to ask your opinion :)
This builds and the packages work for me,
but the /bin contains bash scripts launching the binaries
and they point to the wrong path.

So what I get after build is
nix_store_path/bin/ bash scripts pointing to /var/lib/softether/... wrong path
nix_store_path/var/lib/softether/... where they actually are

Should that be changed in this pr?

[Nobody-alias-N]

Because starting the server or client requires modifying the nix store with sudo
I assume for this package nix_store_path/var/... is supposed to be copied to /var/... before use?

[FliegendeWurst]

Usually the result should be usable without copying it somewhere else.

[FliegendeWurst]

Alright, I would recommend: putting bash in buildInputs, so the scripts get a proper shebang.

Adding substituteInPlace "$out/bin/vpnclient" --replace-fail /var/lib/softether/vpnclient "$out/bin" and similar in postInstall.

[Nobody-alias-N]

Sorry for taking so long to reply, I went to sleep.

[Nobody-alias-N]

Thank you very much for your recommendation and explanation; they are really helpful to me :)

[Nobody-alias-N]

For some reason adding bash to buildInputs did not change the shebang for me but that is probably an issue on my end.

[FliegendeWurst]

It only matters for cross builds or if you set strictDeps = true. (#178468)
The current default (strictDeps = false) means you got the builder shell before.

[Nobody-alias-N]

Thank you for your explanation.
I tried setting strictDeps to true, but that did not change the output for me.
I also tried to cross compile but I was not successful.

I say don't worry about it, it is probably just something on my end, don't waste your time on this.
I just want to make sure I don't misunderstand the part:
in the bash scripts I am supposed to see something like
#!/bin/sh instead of
#!/nix/store/4fvc5fm8bszmkydng1ivrvr5cbvr1g60-bash-5.2p37/bin/sh ?

or is #!/nix/store/4fvc5fm8bszmkydng1ivrvr5cbvr1g60-bash-5.2p37/bin/sh
the correct format I should get, and I just had it from the start?

[FliegendeWurst]

I tried setting strictDeps to true, but that did not change the output for me.

Yes it only mattered before, when you did not have bash in buildInputs.

#!/bin/sh (or similar) is what is provided upstream, we patch it to use our bash.

[FliegendeWurst]

cross is broken for different reasons. If you want, you can include:

diff --git a/pkgs/by-name/so/softether/package.nix b/pkgs/by-name/so/softether/package.nix
index abd112ce5e19..14cdb08a8009 100644
--- a/pkgs/by-name/so/softether/package.nix
+++ b/pkgs/by-name/so/softether/package.nix
@@ -27,10 +27,6 @@ stdenv.mkDerivation (finalAttrs: {
     zlib
   ];
 
-  preConfigure = ''
-    ./configure
-  '';
-
   buildPhase = ''
     mkdir -p $out/bin
     sed -i \
@@ -50,5 +46,7 @@ stdenv.mkDerivation (finalAttrs: {
       "x86_64-linux"
       "aarch64-linux"
     ];
+    # internal build tool hamcorebuilder is difficult to build for the build platform
+    broken = !stdenv.buildPlatform.canExecute stdenv.hostPlatform;
   };
 })

Otherwise I will take care of it in another PR.

[Nobody-alias-N]

Yes it only mattered before, when you did not have bash in buildInputs.

#!/bin/sh (or similar) is what is provided upstream, we patch it to use our bash.

Thank you soo much!

[Nobody-alias-N]

cross is broken for different reasons. If you want, you can include:

Otherwise I will take care of it in another PR.

You already helped me so much I don't want to take away the opportunity from you to get another pr in :)
Thank you, but I will let you have it :)

I can't thank you enough for being so patient with me, so thank you again :)