Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunshine: fix build with cudaSupport #375903

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devusb
Copy link
Contributor

@devusb devusb commented Jan 22, 2025

add cuda_cudart to buildInputs to resolve build failure with cudaSupport

resolves #375741

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 22, 2025
@NovaViper
Copy link
Contributor

@devusb Hey I just tried it again in my flake but got an entirely new error: The package-lock.json in src is not the same as the in /nix/store/3ifp1zlman3wji94xrpplbi1kp4k9gqg-sunshine-ui-2025.118.151840-npm-deps

log.txt

I copied the contents of the PR along the package-lock.json and update.sh files

@devusb
Copy link
Contributor Author

devusb commented Jan 22, 2025

@NovaViper like on build? definitely didn't get that, and neither did OfBorg (see CI checks). can you try again with just a pure clone of this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: sunshine with Cuda Support
2 participants