Port sentry logic #5570
Port sentry logic #5570
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
ChristopherDedominici
force-pushed
the
features/port-sentry-to-V3
branch
from
20855e1 to
48657f1
Compare
ChristopherDedominici
force-pushed
the
features/port-sentry-to-V3
branch
from
48657f1 to
72ca78f
Compare
…:NomicFoundation/hardhat into features/port-sentry-to-V3
ChristopherDedominici
force-pushed
the
features/port-sentry-to-V3
branch
from
72ca78f to
7b80e13
Compare
…:NomicFoundation/hardhat into features/port-sentry-to-V3
| errorMessage = this.#anonymizeMnemonic(errorMessage); | ||
|
|
||
| // the \\ before path.sep is necessary for this to work on windows | ||
| const pathRegex = /\S+[\/\\]\S+/g; |
There was a problem hiding this comment.
Note: This is a bit different, it accepts \ or / in any platform. Previously it used path.sep.
| } | ||
|
|
||
| #isHardhatFile(filename: string): boolean { | ||
| const nomicFoundationPath = path.join("node_modules", "@nomicfoundation"); |
…ures/port-sentry-to-V3
…:NomicFoundation/hardhat into features/port-sentry-to-V3
| * (https://develop.sentry.dev/sdk/event-payloads/exception/), return an | ||
| * anonymized version of the event. | ||
| */ | ||
| public async anonymize(event: any): Promise<either.Either<string, Event>> { |
There was a problem hiding this comment.
Let's replace this with something like:
type AnonymizeResult = {success: true, Event} | {success: false, error:string}so that we don't add fp-ts as a dependency.
|
I was able to get Sentry exceptions through on the test environment with manual testing. It did throw up that our anonymizing is not setup for the I think we deal with this issue when we add Sentry to the CLI's uncaught exception handler. |
…on/hardhat into features/port-sentry-to-V3
Done here |
|
|
||
| interface WordMatch { | ||
| index: number; | ||
| word: string; | ||
| } | ||
|
|
||
| type AnonymizeResult = |
There was a problem hiding this comment.
We should export this type as its part of the Anonymizer API.
No description provided.