Node test runner plugin supporting js tests

[zoeyTM]

closes #5534

[changeset-bot]

⚠️ No Changeset found

Latest commit: c2d5655

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hardhat	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 26, 2024 6:03am

[alcuadrado]

I think the CI is failing due to the pnpm problem that @galargh mentioned

[galargh]

I see you already found the fix in a2290a3 (#5584) 🥳 I just wanted to confirm that without this I had the same issue as CI reported and that defining the references fixes it for me.

[galargh]

Looks great 😸 I left a couple of questions to ensure I understand all the changes being made. I hope you don't mind I'm trying to use the review process as a learning opportunity, too.

The main items I couldn't find definite answers for myself were:

1. Do we want to cover all the test cases outlined in the Design Doc in this iteration?
2. Should hre injection into the context be supported after all or not? I thought imports were supposed to be the only path, but I wanted to double-check.

---

Testing

• Ran pnpm hardhat test in the example-project

Review Checklist (copied from the issue)

• Add a new @ignored/hardhat-node-test-runner package under ./v-next
  • It is called @ignored/hardhat-vnext-node-test-runner which follows the guidelines for v-next packages.
• Implement as a plugin task shim code similar to v2 mocha, that runs the designated test folder js/ts files as tests in Node test runner. Before the tests are run the HRE should be initialized and injected into the context.
  • HRE can be imported in the tests, it does not need to be injected.
• Include the Hardhat custom test reporter in the default execution
• Add @ignored/hardhat-node-test-runner to the example project and add some basic integration tests confirming that testing works and that the hre is being initialized
• Add support for --only to the npx hardhat test command
• Add cli support for testFiles an optional list of test files

Out of Scope (copied from the issue)

• Coverage
• Gas reporting
• Parallel test execution
• Support for console.log in tests

[schaable]

I reviewed the PR, and it looks like Piotr caught everything I would have (and probably more)! 😅 LGTM once these are addressed.

[alcuadrado]

I'll review this PR tomorrow morning

[alcuadrado]

I left a comment to remove a console.log, apart from that this looks ready to be merged