Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run pnpm install to fix the lockfile #5585

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

galargh
Copy link
Member

@galargh galargh commented Aug 8, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

I noticed that the pnpm lockfile is broken on the v-next currently. This is likely because I merged #5574 which brought in main into v-next so it naturally had a lot of changes (including having to rewrite pnpm lock) and then #5541 got merged which likely got tested before and, later, the conflict was too obscure for GitHub to notice.

To fix the lockfile, I just ran pnpm install in the root.

@galargh galargh requested a review from zoeyTM August 8, 2024 08:39
Copy link

changeset-bot bot commented Aug 8, 2024

⚠️ No Changeset found

Latest commit: 2b3bf22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 8:40am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Aug 8, 2024
@galargh galargh added the no changeset needed This PR doesn't require a changeset label Aug 8, 2024
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@galargh galargh merged commit ca8ee82 into v-next Aug 8, 2024
117 checks passed
@galargh galargh deleted the galargh/fix-pnpm-lock branch August 8, 2024 08:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants