Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add zksync as supported network #5597

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: add zksync as supported network #5597

merged 2 commits into from
Sep 12, 2024

Conversation

nikola-bozin-txfusion
Copy link
Contributor

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This PR adds ZKsync network to the supported networks in hardhat-network-helpers.

Testing

  • Manually tested this change on a ZKsync local node in a separate project and made sure that zksync is a development network and that JSON RPC endpoints are ran against ZKsync node.
  • Manually created tests in a separate project to make sure that functionality works in tests too.

@vercel Vercel
Copy link

vercel bot commented Aug 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 11:44am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8fa15e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/hardhat-network-helpers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alcuadrado
Copy link
Member

Hey, thanks for sending this PR.

Can you explain it a bit? zksync isn't a development network. Are you trying to match a zksync dev-mode or something like that?

@alcuadrado alcuadrado added status:needs-more-info There's not enough information to start working on this issue and removed status:triaging labels Sep 1, 2024
@nikola-bozin-txfusion
Copy link
Contributor Author

Hey @alcuadrado , zksync has development network compatible with network-helpers such as Era Test Node. Repo Link:
https://github.com/matter-labs/era-test-node
Their web3 client starts with zksync, so the functionalities from network helpers can be used with this network.

@alcuadrado alcuadrado added no changeset needed This PR doesn't require a changeset and removed status:needs-more-info There's not enough information to start working on this issue no changeset needed This PR doesn't require a changeset labels Sep 8, 2024
@alcuadrado
Copy link
Member

Thanks for the info. Sounds good.

@alcuadrado alcuadrado merged commit 27721a0 into NomicFoundation:main Sep 12, 2024
24 checks passed
@gitpoap-bot gitpoap-bot
Copy link

gitpoap-bot bot commented Sep 12, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@schaable
Copy link
Member

Released in @nomicfoundation/[email protected].

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@kanej kanej

Labels
None yet
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikola-bozin-txfusion @alcuadrado @schaable @kanej