Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from ESCOMP cam6_3_158 to cam6_4_041 #41

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

gold2718
Copy link
Contributor

@gold2718 gold2718 commented Nov 6, 2024

This PR is needed to update Oslo Aero to adapt to the changes from ESCOMP/CAM.
The changes are all to CAM interface shadow files.

addresses NorESMhub/CAM#173

@gold2718 gold2718 added the enhancement New feature or request label Nov 6, 2024
@gold2718 gold2718 added this to the NorESM2.5 milestone Nov 6, 2024
@gold2718 gold2718 self-assigned this Nov 6, 2024
Copy link
Contributor

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that all of these changes are needed to satisfy the new cam7 interfaces - so these look fine to me.

@oyvindseland
Copy link

will look at it before noon today

@oyvindseland
Copy link

As far as I can see this should not change the results, except from specific output variables?

Copy link

@oyvindseland oyvindseland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not see any science problems in the code.

@gold2718 gold2718 merged commit 63d5443 into NorESMhub:noresm_develop Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants