Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting update - upversioned python packages and added log scaling option with associated test case #67

Merged
merged 14 commits into from
Sep 26, 2024

Conversation

pixalytics
Copy link
Contributor

As part of the OGC OSPD project, I wanted to add a log scaling option as that's what's typically used with the Chlorophyll-a data I'm plotting/

I've tested these changes using planemo and within a local Galaxy installation to ensure the test cases have not regressed. However, the Latitude labelling of the two original plots being tested has changed, but this relates to the upversioning of the associated Python modules, see https://psyplot.github.io/examples/maps/example_mapplotters.html

I have added a further test case for the log plotting.

Best Wishes, Sam

@bgruening
Copy link
Collaborator

Thanks a lot @pixalytics!

Can you maybe fix the python linting. I will care about the recommended citation that we should add (the other linting error).

tools/psy-maps/psy-maps.xml Outdated Show resolved Hide resolved
tools/psy-maps/psy-maps.xml Outdated Show resolved Hide resolved
@pixalytics
Copy link
Contributor Author

@bgruening Thanks, yes, I'll work through and update the python linting errors

@pixalytics
Copy link
Contributor Author

@bgruening After a few iterations, I've solved the linting errors for the Python code, but there's still one for the tool linting. Can you check that one, as I don't know how to solve it?

@bgruening
Copy link
Collaborator

Yes I can take care of that one. Our best practices recommend to add a citation to a tool. Any idea what a good citation is?

@pixalytics
Copy link
Contributor Author

psyplot suggest citing the following: Sommer, P. S.: The psyplot interactive visualization framework, The Journal of Open Source Software, 2, doi:10.21105/joss.00363, https://doi.org/10.21105/joss.00363, 2017.

@bgruening
Copy link
Collaborator

Can you please give me access to modify your PR. Or please add to the tool.

    <citations>
        <citation type="doi">10.21105/joss.00363</citation>
    </citations>

Thanks!

@pixalytics
Copy link
Contributor Author

@bgruening I had a look but couldn't find a way to give you access to modify the PR - it seems I should have checked a box when I created the PR.

@bgruening
Copy link
Collaborator

Can you maybe remove this TODO https://github.com/NordicESMhub/galaxy-tools/pull/67/files#diff-63a6ea305b97f7876666f633060232f80982e08506b6f9f570ca5ba00b52af82R191 or ideally add more help?

For the PR, it should look like that:

grafik
Allow edits by maintainers

@pixalytics
Copy link
Contributor Author

For some reason, I just see this
image

Copy link
Collaborator

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks its green and looks great!

@bgruening bgruening merged commit d330adb into NordicESMhub:master Sep 26, 2024
10 checks passed
@bgruening
Copy link
Collaborator

Which Galaxy server are you using? This tool can now be updated at this server.

@pixalytics
Copy link
Contributor Author

I've been using https://aqua.usegalaxy.eu/

@bgruening
Copy link
Collaborator

ok, I have updated the server, Enjoy!

@pixalytics pixalytics deleted the plotting-update branch September 27, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants