-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting update - upversioned python packages and added log scaling option with associated test case #67
Plotting update - upversioned python packages and added log scaling option with associated test case #67
Conversation
Thanks a lot @pixalytics! Can you maybe fix the python linting. I will care about the recommended citation that we should add (the other linting error). |
@bgruening Thanks, yes, I'll work through and update the python linting errors |
Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Björn Grüning <[email protected]>
@bgruening After a few iterations, I've solved the linting errors for the Python code, but there's still one for the tool linting. Can you check that one, as I don't know how to solve it? |
Yes I can take care of that one. Our best practices recommend to add a citation to a tool. Any idea what a good citation is? |
psyplot suggest citing the following: Sommer, P. S.: The psyplot interactive visualization framework, The Journal of Open Source Software, 2, doi:10.21105/joss.00363, https://doi.org/10.21105/joss.00363, 2017. |
Can you please give me access to modify your PR. Or please add to the tool.
Thanks! |
@bgruening I had a look but couldn't find a way to give you access to modify the PR - it seems I should have checked a box when I created the PR. |
Can you maybe remove this TODO https://github.com/NordicESMhub/galaxy-tools/pull/67/files#diff-63a6ea305b97f7876666f633060232f80982e08506b6f9f570ca5ba00b52af82R191 or ideally add more help? For the PR, it should look like that: |
Co-authored-by: Björn Grüning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks its green and looks great!
Which Galaxy server are you using? This tool can now be updated at this server. |
I've been using https://aqua.usegalaxy.eu/ |
ok, I have updated the server, Enjoy! |
As part of the OGC OSPD project, I wanted to add a log scaling option as that's what's typically used with the Chlorophyll-a data I'm plotting/
I've tested these changes using planemo and within a local Galaxy installation to ensure the test cases have not regressed. However, the Latitude labelling of the two original plots being tested has changed, but this relates to the upversioning of the associated Python modules, see https://psyplot.github.io/examples/maps/example_mapplotters.html
I have added a further test case for the log plotting.
Best Wishes, Sam