feat: support hd youtube placeholders #326
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller placeholder on mobile devices
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joaocdvr
changed the title
|
Hey @transitive-bullshit, do you mind telling me why did the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The youtube video placeholder/thumbnail is too low resolution for it to look good on larger screens, at least for my use case.
My proposal is to add an
hasOnlyHDVideosprop to theNotionRenderercomponent that changes theLiteYoutubeEmbedplaceholder image URL coming from YouTube's API (img.youtube.com) resolution fromhqdefaulttomaxresdefault.Additionally, I added the window width value to the NotionContext via the
useWindowSizehook fromreact-useto be able to switch betweenhqdefaultandmaxresdefaultdepending on the window screen width ifhasOnlyHDVideos === true.The reason why I didn't simply switch the current resolution from
hqdefaulttomaxresdefaultis because, if the embedded video is not HD, the placeholder doesn't exist. For example:Notion Test Page ID
7cac0f415bd4438a95fda8871f02e9ad