Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networking improvements #146

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Networking improvements #146

merged 2 commits into from
Dec 22, 2023

Conversation

kristoff3r
Copy link
Collaborator

@kristoff3r kristoff3r commented Nov 29, 2023 •
edited
Loading

  • Add error handling to receive_messages
  • Add get_authentication_status
  • Add run_callbacks

@kristoff3r
Networking improvements
de970df 
* Add error handling to `receive_messages`
* Add `get_authentication_status`
@kristoff3r
Add run_callbacks to networking_sockets
e9f7d2f
@kristoff3r kristoff3r force-pushed the receive-messages-error branch from 8208d66 to e9f7d2f Compare November 29, 2023 15:58
TrustNoOneElse
TrustNoOneElse approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@TrustNoOneElse TrustNoOneElse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care, looks good to me

@kristoff3r kristoff3r merged commit 7b32b14 into Noxime:master Dec 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceifa ceifa ceifa approved these changes

@TrustNoOneElse TrustNoOneElse TrustNoOneElse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristoff3r @TrustNoOneElse @ceifa