[17.0][MIG] automation_oca: Migration to 17.0 #10

dedinside1337 · 2024-09-25T11:04:34Z

This is my first migration.
Modified:
-added _request_handler method to test_automation_mail.py
-modified automation_step and automation_graph widgets
-rename get_mail_values to _prepare_mail_values in mail_compose_message.py
-rename _send_prepare_body to _prepare_outgoing_body in mail_mail.py
-changed return value of _search method in automation_record.py

Currently translated at 100.0% (218 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/it/

Currently translated at 96.7% (211 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/es/

Currently translated at 61.9% (135 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/fr/

This commit adds the corresponding imports and preparation code for using some variables and expressions like `today()`, `datetime`, `user`, etc in the domain (filter) of the automation configuration.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/

Currently translated at 100.0% (220 of 220 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/it/

updates

etobella · 2024-12-05T16:39:14Z

/ocabot rebase

OCA-git-bot · 2024-12-05T16:39:24Z

Congratulations, PR rebased to 17.0.

percevaq

Functionnal review OK

etobella

I have several doubts on the code...

etobella · 2024-12-11T20:42:33Z

automation_oca/models/automation_configuration.py

@@ -31,26 +20,13 @@ class AutomationConfiguration(models.Model):
    domain = fields.Char(
        required=True,
        default="[]",
+        help="Filter to apply",


Why did you simplify the help?

The help should not have been modified

etobella · 2024-12-11T20:45:53Z

automation_oca/models/automation_configuration.py

        Also, we need to check by autencity field if defined.

        In order to do this, we will add some extra joins on the query of the domain
        """
-        eval_context = self._get_eval_context()
-        domain = safe_eval(self.domain, eval_context)
+        domain = safe_eval(self.domain)


Why did you remove the context?

In this case, the function that returns the domain in eval_context was removed and it is not correct. The function _get_eval_context should be there and the code should remain as it was:

eval_context = self._get_eval_context() domain = safe_eval(self.domain, eval_context)

etobella · 2024-12-11T20:46:37Z

automation_oca/models/automation_configuration.py

            "id",
            "automation_record",
            "res_id",
            "automation_record",
-            "{rhs}.model = %s AND {rhs}.configuration_id = %s AND "


You removed all the logic, why?

In both cases, keeping the previous code since they have changed the number of fields returned would give an error:
alias = query.left_join(
TypeError: Query.left_join() takes 6 positional arguments but 8 were given
From what I see, the implementation in the migration is correct

But he has removed all the logic of the query then. We need to find something to apply it.

etobella · 2024-12-11T20:46:52Z

automation_oca/models/automation_configuration.py

@@ -267,9 +228,6 @@ def _get_automation_records_to_create(self):
                "automation_record",
                "res_id",
                "automation_record_linked",
-                "{rhs}.model = %s AND {rhs}.configuration_id = %s AND "


In both cases, keeping the previous code since they have changed the number of fields returned would give an error:
alias = query.left_join(
TypeError: Query.left_join() takes 6 positional arguments but 8 were given
From what I see, the implementation in the migration is correct

etobella · 2024-12-11T20:48:05Z

automation_oca/static/src/fields/automation_graph/automation_graph.esm.js

                    return pt.x;
                }),
                datasets: [
                    {
                        backgroundColor: "#4CAF5080",
                        borderColor: "#4CAF50",
-                        data: this.props.value.done,
+                        data: this.props.record.data.graph_data.done,


The idea of using value is reusing the widget in other fields if necessary. Why did you apply this change?

The implementation in this case is correct, the information is brought from this.props.record.data.graph_data

I think you did not understant me. I know it is implemented in this field, however, if we do this, the widget will only work if we have this specific field name in the model and the field is added in the view. With my suggestion, you will not have this issue.

mjavint · 2025-01-07T17:15:21Z

automation_oca/static/src/fields/automation_graph/automation_graph.esm.js

+    setup() {
+        this.chart = null;
+        this.canvasRef = useRef("canvas");
+        onWillStart(async () => await loadBundle("web.chartjs_lib"));


loadJS was replaced by loadBundle, loadJS was well implemented. Why was it changed?

etobella and others added 19 commits September 25, 2024 11:22

[ADD] automation_oca

562e5aa

[IMP] automation_oca: README.md

c9deeca

[UPD] Update automation_oca.pot

1406128

[BOT] post-merge updates

ffbcef9

Added translation using Weblate (Italian)

ac14bed

Translated using Weblate (Italian)

90253df

Currently translated at 100.0% (218 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/it/

Translated using Weblate (Italian)

0f158a7

Currently translated at 100.0% (218 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/it/

Added translation using Weblate (Spanish)

bf4da25

Translated using Weblate (Spanish)

907deed

Currently translated at 96.7% (211 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/es/

Added translation using Weblate (French)

519e5e5

Translated using Weblate (French)

390f98e

Currently translated at 61.9% (135 of 218 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/fr/

[IMP] automation_oca: Allow some expressions in domain

d20aab1

This commit adds the corresponding imports and preparation code for using some variables and expressions like `today()`, `datetime`, `user`, etc in the domain (filter) of the automation configuration.

[16.0] automation_oca : add demo and help for new domain options

d19a00b

[UPD] Update automation_oca.pot

b3a1d49

[BOT] post-merge updates

ebce4bf

Update translation files

def93c3

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/

Translated using Weblate (Italian)

f2f6744

Currently translated at 100.0% (220 of 220 strings) Translation: automation-16.0/automation-16.0-automation_oca Translate-URL: https://translation.odoo-community.org/projects/automation-16-0/automation-16-0-automation_oca/it/

[IMP] automation_oca: pre-commit auto fixes

30d7167

[MIG] automation_oca: Migration to 17.0

a8bef8e

updates

dedinside1337 force-pushed the 17.0-mig-automation_oca branch from afc6281 to a8bef8e Compare September 25, 2024 12:18

Christian-RB mentioned this pull request Nov 27, 2024

17.0 mig automation #14

Closed

percevaq approved these changes Dec 11, 2024

View reviewed changes

etobella requested changes Dec 11, 2024

View reviewed changes

mjavint reviewed Jan 7, 2025

View reviewed changes

mjavint mentioned this pull request Jan 16, 2025

[17.0] [MIG] automation_oca: Migration to 17.0 #16

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] automation_oca: Migration to 17.0 #10

[17.0][MIG] automation_oca: Migration to 17.0 #10

dedinside1337 commented Sep 25, 2024 •

edited

Loading

etobella commented Dec 5, 2024

OCA-git-bot commented Dec 5, 2024

percevaq left a comment

etobella left a comment

etobella Dec 11, 2024

mjavint Jan 7, 2025

etobella Dec 11, 2024

mjavint Jan 7, 2025

etobella Dec 11, 2024

mjavint Jan 7, 2025

etobella Jan 7, 2025

mjavint Jan 7, 2025 •

edited

Loading

etobella Dec 11, 2024

mjavint Jan 7, 2025

etobella Dec 11, 2024

mjavint Jan 7, 2025

etobella Jan 7, 2025

mjavint Jan 7, 2025

[17.0][MIG] automation_oca: Migration to 17.0 #10

Are you sure you want to change the base?

[17.0][MIG] automation_oca: Migration to 17.0 #10

Conversation

dedinside1337 commented Sep 25, 2024 • edited Loading

etobella commented Dec 5, 2024

OCA-git-bot commented Dec 5, 2024

percevaq left a comment

Choose a reason for hiding this comment

etobella left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjavint Jan 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dedinside1337 commented Sep 25, 2024 •

edited

Loading

mjavint Jan 7, 2025 •

edited

Loading