[16.0][MIG] crm_phone: Migration to 16.0 #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move more asterisk-independant code to base_phone module and create new asterisk-independant modules - rename module asterisk_popup to base_phone_popup - add ability to get callerid names not only from partners, but also from leads, employees, applicants, etc... - same for auto pop-up : not only for partners, but also for leads, employees, etc...
…letely new behavior As a consequence, the modules asterisk_click2dial_event and asterisk_click2dial_crm_claim have been dropped New wizard "Number not found" (inspired by the old "Open Calling Partner" with many enhancements), which is called by base_phone_popup and Open Caller Formatting of number for click2dial is now handled by the phonenumbers lib: as a consequence, 3 fields have been dropped from asterisk.server (national_prefix, international_prefix, country_prefix) New option 'dial_button_invisible' in the phone widget New sample script asterisk_click2dial/scripts/openerp_popup_timeout.sh Update translations and some module descriptions All the modules are now PEP8 compliant
…%' myself Add logger.error in the function used by the inherit of write/create, for easier debugging when it is called by a webservice Add . in PATH in my sample shell scripts Code cleanup (thank you flake8 !)
Remove old-style icons on buttons
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Re-organise the codebase to prepare the arrival of a new module for a telephony system other than Asterisk
… from the country of the object (partner, lead, hr.applicant), not from the country of the user... a very wanted feature !
Use the new phone attributes on objects inside the code
Some code clean-up and re-organisation in the generic modules Prepare the removal of the module asterisk_click2dial_crm
Code cleanup, fixes, small enhancements The code to extract the calling party number from the list of channels is now inheritable
Proper name_get for callerid for applicants Small bugfixes/enhancements
The revolution in the connector-telephony project has started !
Allow simultaneous use of country_field and partner_field in field definition
Replace spaces by non-breaking-spaces
Remove code that is now useless with new API
Remove crm_claim_phone, because there is no crm_claim module in v10 Start to port asterisk_click2dial (JS code still needs to be ported)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-14.0/connector-telephony-14.0-crm_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-crm_phone/
Currently translated at 9.8% (10 of 102 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-crm_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-crm_phone/it/
Currently translated at 9.8% (10 of 102 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-crm_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-crm_phone/it/
Currently translated at 16.6% (17 of 102 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-crm_phone Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-crm_phone/sl/
|
/ocabot migration crm_phone |
TelmoSuarezConinpe
force-pushed
the
16.0-mig-crm_phone
branch
from
7b1863b to
7ee1691
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi @TelmoSuarezConinpe can you fix the tests? |
github-actions
bot
removed
the
stale
TelmoSuarezConinpe
force-pushed
the
16.0-mig-crm_phone
branch
4 times, most recently
from
8d70b14 to
9b66b6a
Compare
TelmoSuarezConinpe
force-pushed
the
16.0-mig-crm_phone
branch
from
9b66b6a to
64421a9
Compare
|
@AlexPForgeFlow Fixed. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi @TelmoSuarezConinpe can you please rebase and fix conflicts? |
github-actions
bot
removed
the
stale
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@pedrobaeza Is there an issue blocking the merge of this PR? I can fix it and open a new PR. Edit: It looks like this module has some conflicts with OCA/crm/crm_phonecall module since they both define "crm.phonecall" model. Maybe we can remove the duplicated codes in this module and just keep the additional things like working with base_phone's reformat_all_phonenumbers wizard. What do you suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration.
This PR depends on #300
Replaces #301