[16.0] [MIG] asterisk_click2dial: Migration to 16.0 #319

luisDIXMIT · 2024-04-12T12:02:41Z

Standard migration.

Long life to the asterisk_click2dial module for OpenERP !

- option to allow the use of phone numbers in National format, as discussed with Albert. This option is on the definition of the server. -> required a large change of the reformat number process - added exact link to documentation in module description - some clean-up

but he also made the change in the name of the SIP header ! This commit reverts this mistake.

In fact, it corresponds to the 'Timeout' instruction for the Asterisk Manager

Add French translation for these messages.

- Convert the comments for the functions to the standard style

Added "active" field on asterisk.server object. In order to access all the Asterisk servers, included the desactivated ones, I added a view dedicated to the object asterisk.server, which is accessible under Administration > Configuration.

Thanks to Bernat Brunet from NaN for pointing this out.

Make phone and mobile fields searchable Took into account some pylint coding convention suggestions

- we now handle the fact that phone numbers may contain spaces or special chars such in OpenERP, which is often the case in real life - check input number

Added a comment about the user rights.

… feature Update module description.

Update in comments

…ber in the callerID instruction to Asterisk. Patch courtesy of Marcel van der Boom. Thanks for your feedback !

Accoring to my tests and the info I got, SIP phones support UTF-8 fine - Create a command line option to convert the name from UTF-8 to ASCII (-a) - add default parameter to the help message

…a priority on the res.partner view. Better handling of check functions when there are several ids.

…rm1 and removes the "mobile" field, so I need to change the priority to this view too.

Thanks to Todd Johnson for pointing out this mistake.

…k server now inherit from the tree/form view in the company form.

Changed view names Great solution (thanks to Sebastien for finding it !) to avoid having 2 different tree&form views for asterisk server.

Larger phone field in res_partner_address (smaller 'dial' button)

. adds debug message . starts to better manage character encoding in the networking code... but I still need more info about AMI on this.

- now parses answers received from Asterisk and display errors to the user - now properly encodes the requests sent to Asterisk in ASCII (AMI doesn't support other charsets unfortunately) - required fields are now required=True - Single constraint function for all asterisk.server fields - Fields that shouldn't have non-ascii caracters are not validated if they have non-ASCII caracters (including CallerID) - clean-up error message code - if no Asterisk server is defined for a user, it takes the first Asterisk serve r defined - methods now always return something

Remove print

Currently translated at 7.6% (7 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/it/

Currently translated at 8.7% (8 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/sl/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/

Currently translated at 100.0% (91 of 91 strings) Translation: connector-telephony-14.0/connector-telephony-14.0-asterisk_click2dial Translate-URL: https://translation.odoo-community.org/projects/connector-telephony-14-0/connector-telephony-14-0-asterisk_click2dial/es/

etobella

Tested locally

cvinh · 2024-04-17T14:52:28Z

asterisk_click2dial/models/asterisk_server.py

@@ -25,7 +25,7 @@ class AsteriskServer(models.Model):
    ip_address = fields.Char(string="Asterisk IP address or DNS", required=True)
    port = fields.Integer(
        required=True,
-        default=5038,
+        default=8088,


default port for AMI is 5038 indeed
8088 is for the web interface

AMI is no longer used. It was changed on v14

OMG, time goes fast

cvinh · 2024-04-17T14:54:20Z

asterisk_click2dial/models/asterisk_server.py

+            "tag": "display_notification",
+            "params": {
+                "type": "success",
+                "message": _("Your request has been successfully sent"),


Why did you change the message ?
IMHO, the original one is better because the connexion is towards ARI

cvinh · 2024-04-17T16:26:43Z

asterisk_click2dial/models/asterisk_server.py

        return ast_server, auth, url

    def test_ari_connection(self):
        self.ensure_one()
        auth = (self.login, self.password)
-        url = "http://%s:%s/ari/asterisk/info" % (self.ip_address, self.port)
+        url = f"http://{self.ip_address}:{self.port}/ari/asterisk/info"
        try:
            res = requests.get(url, auth=auth, timeout=TIMEOUT)
        except Exception as e:
            raise UserError from None(


I have models/asterisk_server.py", line 159, in test_ari_connection
TypeError: 'NoneType' object is not callable

Thanks for your review, comments attended!

etobella · 2024-05-05T11:12:20Z

/ocabot migration asterisk_click2dial

OCA-git-bot · 2024-05-05T18:36:45Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

nimarosa · 2024-05-05T18:37:13Z

Tested and working ok. Merging.

/ocabot merge nobump

OCA-git-bot · 2024-05-05T18:37:21Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-319-by-nimarosa-bump-nobump, awaiting test results.

OCA-git-bot · 2024-05-05T18:41:07Z

Congratulations, your PR was merged at 8b3a393. Thanks a lot for contributing to OCA. ❤️

Alexis de Lattre added 30 commits April 16, 2024 15:56

Initial import.

51faab4

Long life to the asterisk_click2dial module for OpenERP !

Vianney changed the name of the 'alert-info' field to 'alert_info'...

97ca6f1

but he also made the change in the name of the SIP header ! This commit reverts this mistake.

[FIX] WaitTime parameter is now really taken into account

688d92d

In fact, it corresponds to the 'Timeout' instruction for the Asterisk Manager

Make error messages displayed on screen translatable.

7496ea9

Add French translation for these messages.

- Add copyright headers in XML files

12d1b78

- Convert the comments for the functions to the standard style

Country_prefix is now a "required" field.

a9b6810

Added "active" field on asterisk.server object. In order to access all the Asterisk servers, included the desactivated ones, I added a view dedicated to the object asterisk.server, which is accessible under Administration > Configuration.

Check that the user has a callerID.

e3f4451

Thanks to Bernat Brunet from NaN for pointing this out.

First implementation of get_name_from_phone_number function

80e9f09

Make phone and mobile fields searchable Took into account some pylint coding convention suggestions

Much better function get_name_from_phone_number :

0882242

- we now handle the fact that phone numbers may contain spaces or special chars such in OpenERP, which is often the case in real life - check input number

Add AGI script and its wrapper to manage timeout.

6960720

Don't put the admin user by default, it's not a good example.

ff3fad2

Added a comment about the user rights.

Add a group "Asterisk CallerID" decidated to the CallerID name lookup…

00f2040

… feature Update module description.

Better context handling

dbab71a

Update in comments

Update URL of the module documentation.

f85322a

[FIX] There shouldn't be any space between the name and the phone num…

d81682e

…ber in the callerID instruction to Asterisk. Patch courtesy of Marcel van der Boom. Thanks for your feedback !

- Send CallerID to Asterisk as UTF-8 by default

262ba88

Accoring to my tests and the info I got, SIP phones support UTF-8 fine - Create a command line option to convert the name from UTF-8 to ASCII (-a) - add default parameter to the help message

Networking code is now IPv6-ready

5c70c70

[FIX] Avoid a view conflict with the "base_contact" module by adding …

2c778c1

…a priority on the res.partner view. Better handling of check functions when there are several ids.

[FIX] Base_contact also inherit the view base.view_partner_address_fo…

15a07b5

…rm1 and removes the "mobile" field, so I need to change the priority to this view too.

[FIX] Wrong if condition fixed

0a0a977

Thanks to Todd Johnson for pointing out this mistake.

Avoid code duplication in views : the full tree/form view for Asteris…

81fe673

…k server now inherit from the tree/form view in the company form.

Changed author name to Akretion

8fe8471

Changed view names Great solution (thanks to Sebastien for finding it !) to avoid having 2 different tree&form views for asterisk server.

Add support for XML-RPC secure with SSL.

42963df

Fallback to utf-8 if sys.stdout.encoding fails.

5f10e07

Create a dedicated Tab in the res_users view.

5f3f7ed

Larger phone field in res_partner_address (smaller 'dial' button)

Start to clean the networking code :

86e005f

. adds debug message . starts to better manage character encoding in the networking code... but I still need more info about AMI on this.

Cosmetic changes.

e31f4c4

Convert to new logger API of OpenERP 6.1

24cd10a

Remove print

mymage and others added 8 commits April 16, 2024 15:56

[UPD] Update asterisk_click2dial.pot

331dc91

asterisk_click2dial 14.0.2.0.0

b7610a9

[UPD] README.rst

5a5f7bb

[IMP] asterisk_click2dial: pre-commit auto fixes

6bd81eb

luisDIXMIT force-pushed the 16.0-mig-asterisk_click2dial branch from 7dab335 to e899cc2 Compare April 16, 2024 13:58

etobella approved these changes Apr 16, 2024

View reviewed changes

cvinh suggested changes Apr 17, 2024

View reviewed changes

cvinh reviewed Apr 17, 2024

View reviewed changes

[MIG] asterisk_click2dial: Migration to 16.0

0295aec

luisDIXMIT force-pushed the 16.0-mig-asterisk_click2dial branch from e899cc2 to 0295aec Compare April 19, 2024 07:44

etobella mentioned this pull request May 5, 2024

Migration to version 16.0 #275

Open

3 tasks

OCA-git-bot added this to the 16.0 milestone May 5, 2024

cvinh approved these changes May 5, 2024

View reviewed changes

OCA-git-bot added the approved label May 5, 2024

cvinh mentioned this pull request May 5, 2024

[17.0] [MIG] asterisk_click2dial: Migration to 17.0 #317

Merged

nimarosa approved these changes May 5, 2024

View reviewed changes

OCA-git-bot added the ready to merge label May 5, 2024

OCA-git-bot added the bot is merging ⏳ label May 5, 2024

OCA-git-bot merged commit 8212ea0 into OCA:16.0 May 5, 2024
5 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [MIG] asterisk_click2dial: Migration to 16.0 #319

[16.0] [MIG] asterisk_click2dial: Migration to 16.0 #319

luisDIXMIT commented Apr 12, 2024

etobella left a comment

cvinh Apr 17, 2024

etobella Apr 17, 2024

cvinh Apr 17, 2024

cvinh Apr 17, 2024 •

edited

Loading

cvinh Apr 17, 2024

luisDIXMIT Apr 19, 2024

etobella commented May 5, 2024

OCA-git-bot commented May 5, 2024

nimarosa commented May 5, 2024

OCA-git-bot commented May 5, 2024

OCA-git-bot commented May 5, 2024

[16.0] [MIG] asterisk_click2dial: Migration to 16.0 #319

[16.0] [MIG] asterisk_click2dial: Migration to 16.0 #319

Conversation

luisDIXMIT commented Apr 12, 2024

etobella left a comment

Choose a reason for hiding this comment

cvinh Apr 17, 2024

Choose a reason for hiding this comment

etobella Apr 17, 2024

Choose a reason for hiding this comment

cvinh Apr 17, 2024

Choose a reason for hiding this comment

cvinh Apr 17, 2024 • edited Loading

Choose a reason for hiding this comment

cvinh Apr 17, 2024

Choose a reason for hiding this comment

luisDIXMIT Apr 19, 2024

Choose a reason for hiding this comment

etobella commented May 5, 2024

OCA-git-bot commented May 5, 2024

nimarosa commented May 5, 2024

OCA-git-bot commented May 5, 2024

OCA-git-bot commented May 5, 2024

cvinh Apr 17, 2024 •

edited

Loading