[16.0][l10n_br_fisccal] remove nbm #3575
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
de accordo com chatGPT foi super abandonado a classificação NBM (Nomenclatura Brasileira de Mercadorias):
Eu acho que a gente implementou as definições fiscais de acordo com o NBM 10 anos atrás porque foi assim que alguns clientes nossos descreveram as regras fiscais deles por motivos historicos. Mas realmente parece que não faz sentido manter o codigo do NBM hoje. Jà que vai vir mudanças pela reforma tributaria é importante a gente ir limpando a casa tb para não ficar acumulando código legacy...
Além dos 13400 linhas dos arquivos csv lentos de carregar a cada criação de banco, isso tira uns 500 de código morto do modulo l10n_br_fiscal.
cc @renatonlima