[16.0] [MIG] website_sale_product_pack: Migration to 16.0 #135
Conversation
Compatibility module between sale_product_pack and website_sale TT30385
Done for e-commerce compatibility purposes, althoug it's more performant indeed.
Create and select a specific pricelist for avoiding problems in integrated environments where the default pricelist currency has been changed.
When the cart is confirmed, a price recalculation is triggered for every order line. This is wrong for detailed totalized packs, which lines should be at 0. TT38186
alvaro-domatix
changed the title
alvaro-domatix
force-pushed
the
16.0-mig-website_sale_product_pack
branch
6 times, most recently
from
7e9d549 to
13d14d0
Compare
alvaro-domatix
force-pushed
the
16.0-mig-website_sale_product_pack
branch
5 times, most recently
from
07cd90a to
f4afb50
Compare
|
Hi, @ernestotejeda @pedrobaeza ! I would appreciate if you could review this and #134. |
pedrobaeza
changed the title
|
/ocabot migration website_sale_product_pack I'm not the most suitable for reviewing this. @chienandalu if you may? |
|
Functional review, LGTM. As an small improvement (maybe not here), if Pack Display Type is "Detailed" once we add the pack to the cart I think the number of items should be the sum of the child lines instead of the number of packs.
|
|
Hi @alvaro-domatix i'm testing this and looks good! But, I notice a problem with packs detailed per components. On website the price is computed in a wrong way. Do you have any idea about that ? |
|
Hi @alvaro-domatix, @pedrobaeza and @chienandalu |
| @@ -4,10 +4,15 @@ | |||
| "name": "Website Sale Product Pack", | |||
| "category": "E-Commerce", | |||
| "summary": "Compatibility module of product pack with e-commerce", | |||
| "version": "13.0.1.0.2", | |||
| "version": "16.0.1.0.3", | |||
There was a problem hiding this comment.
You just need to bump the major version and reset the minor digits :)
| "version": "16.0.1.0.3", | |
| "version": "16.0.1.0.0", |
| # Neccessary for the website_sale_product_pack module because the price in /shop | ||
| # is calculated by the product.template.price_compute method | ||
| def price_compute( | ||
| self, price_type, uom=False, currency=False, company=False, date=False | ||
| ): |
There was a problem hiding this comment.
Wouldn't this override belong to the base module? Isn't there a common method there we can use?
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
| def _cart_update( | ||
| self, product_id=None, line_id=None, add_qty=0, set_qty=0, **kwargs | ||
| ): | ||
| """We need to keep the discount defined on the components when checking out. | ||
| Also when a line comes from a totalized pack, we should flag it to avoid | ||
| changing it's price in a cart step.""" | ||
| line = self.env["sale.order.line"].browse(line_id) | ||
| if line and line.pack_parent_line_id: | ||
| pack = line.pack_parent_line_id.product_id | ||
| detailed_totalized_pack = ( | ||
| pack.pack_type == "detailed" | ||
| and pack.pack_component_price in {"totalized", "ignored"} | ||
| ) | ||
| return super( | ||
| SaleOrder, | ||
| self.with_context( | ||
| pack_discount=line.discount, | ||
| detailed_totalized_pack=detailed_totalized_pack, | ||
| ), | ||
| )._cart_update(product_id, line_id, add_qty, set_qty, **kwargs) | ||
| return super()._cart_update(product_id, line_id, add_qty, set_qty, **kwargs) |
There was a problem hiding this comment.
| def _cart_update( | |
| self, product_id=None, line_id=None, add_qty=0, set_qty=0, **kwargs | |
| ): | |
| """We need to keep the discount defined on the components when checking out. | |
| Also when a line comes from a totalized pack, we should flag it to avoid | |
| changing it's price in a cart step.""" | |
| line = self.env["sale.order.line"].browse(line_id) | |
| if line and line.pack_parent_line_id: | |
| pack = line.pack_parent_line_id.product_id | |
| detailed_totalized_pack = ( | |
| pack.pack_type == "detailed" | |
| and pack.pack_component_price in {"totalized", "ignored"} | |
| ) | |
| return super( | |
| SaleOrder, | |
| self.with_context( | |
| pack_discount=line.discount, | |
| detailed_totalized_pack=detailed_totalized_pack, | |
| ), | |
| )._cart_update(product_id, line_id, add_qty, set_qty, **kwargs) | |
| return super()._cart_update(product_id, line_id, add_qty, set_qty, **kwargs) | |
| def _cart_update( | |
| self, *args, **kwargs | |
| ): | |
| """We need to keep the discount defined on the components when checking out. | |
| Also when a line comes from a totalized pack, we should flag it to avoid | |
| changing it's price in a cart step.""" | |
| line_id = kwargs.get("line_id") | |
| if line_id: | |
| line = self.env["sale.order.line"].browse(line_id) | |
| if line and line.pack_parent_line_id: | |
| pack = line.pack_parent_line_id.product_id | |
| detailed_totalized_pack = ( | |
| pack.pack_type == "detailed" | |
| and pack.pack_component_price in {"totalized", "ignored"} | |
| ) | |
| return super( | |
| SaleOrder, | |
| self.with_context( | |
| pack_discount=line.discount, | |
| detailed_totalized_pack=detailed_totalized_pack, | |
| ), | |
| )._cart_update(*args, **kwargs) | |
| return super()._cart_update(*args, **kwargs) |
@alvaro-domatix Odoo has recently made these changes and now I have an error caused by this module and that I have been able to solve in this way. Can you apply the changes? Or if you think it should be done another way...
File "/odoo/odoo/addons/website_sale_delivery/models/sale_order.py", line 76, in _cart_update
return super()._cart_update(*args, **kwargs)
File "/oca/product-pack/website_sale_product_pack/models/sale_order.py", line 29, in _cart_update
return super()._cart_update(product_id, line_id, add_qty, set_qty, **kwargs)
File "/odoo/odoo/addons/website_sale_loyalty/models/sale_order.py", line 160, in _cart_update
product_id, set_qty = kwargs['product_id'], kwargs.get('set_qty')
KeyError: 'product_id'
|
Superseded by #165 |
No description provided.