[17][FIX]product_pack: args in _get_product_price/s methods #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ernestotejeda, |
mav-adhoc
force-pushed
the
17.0-h-84553-mav-1
branch
from
02e0a0e to
ac6c88d
Compare
|
@pedrobaeza Could you review this PR instead? Thanks! |
|
I still don't see what motivates this change. |
|
Please put on the commit message and here the absolute link to the method signature that is changing. |
The arguments of the methods '_get_product_price/s' changed on product_pricelist on native odoo from (self, product, quantity, uom=None, date=False, **kwargs) to (self, product, *args, **kwargs). Commit of the change in Odoo: odoo/odoo@83c5257#diff-21fdb0b99c09254c9445e27ceee2d2e27503e93d9dd99481c010d92226db6f75
mav-adhoc
force-pushed
the
17.0-h-84553-mav-1
branch
from
ac6c88d to
436e424
Compare
|
@pedrobaeza done! |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8d73597. Thanks a lot for contributing to OCA. ❤️ |
marielejeune
pushed a commit
to acsone/product-pack
that referenced
this pull request
Jan 9, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-product-pack
that referenced
this pull request
Jan 14, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-product-pack
that referenced
this pull request
Jan 17, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
adhoc-cicd-bot
pushed a commit
to adhoc-cicd/oca-product-pack
that referenced
this pull request
Jan 17, 2025
…scount. (OCA#197) Formerly was only taking into account the product packs discount, now take into account both discounts. Also we simplify the way that get_sale_order_line_vals works and now is simplier and use Odoo's onchange methods to compute the lines values. [FIX] product_pack: Pack component now have the tax of the company (OCA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company. [FIX] product_pack: compute proper components prices (OCA#199) In some cases the values were prefetched and it was throwing bad prices. we add prefetch_fields to the context of the packs and that solve it. [FIX/IMP] product_pack: Allow modify pack and do not reset after confirm website sale order (#201) * [FIX] product_pack: Do not reset packs components when confirm sale order. If a sale order is updated from the website whrn confirm the order we do not expand the pack, we usit as it is. * [ADD] product_pack: Allow modify pack from backend/website Now we can choose if the product can be modified in the only int he backend or if can be modified also in the frontend by the customers. * [FIX] lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments of the methods '_get_product_price' and '_get_product_prices' changed on product_pricelist on native odoo from (self, product, quantity, uom=None, date=False, **kwargs) to (self, product, *args, **kwargs).
Commit of the change in Odoo: odoo/odoo@83c5257#diff-21fdb0b99c09254c9445e27ceee2d2e27503e93d9dd99481c010d92226db6f75