[14.0][FIX] rma_sale_mrp: _check_rma_invoice_lines_qty

[mt-software-de]

checks now only lines with a phantom_bom_product set

If we are trying to post a refund for rma without kit and a lower qty than defined in the rma.
There will no error thrown, as designed here

rma/rma/models/account_move.py

Line 30 in 50d86ae

def action_post(self):

[OCA-git-bot]

Hi @chienandalu,
some modules you are maintaining are being modified, check this out!

[mt-software-de]

@pedrobaeza and @chienandalu could you please do the review.

[pedrobaeza]

Can you please add steps to reproduce the problem?

Also a regression test would be welcome.

[mt-software-de]

Can you please add steps to reproduce the problem?

Also a regression test would be welcome.

You can reproduce the problem if you install rma_sale_mrp with demo data and the run the tests of the base rma module

[pedrobaeza]

Tests are not re-entrant by default. We have this module installed, and our users do both type of RMA without problem, so I insist in a reproducible steps to reproduce the problem.

[mt-software-de]

Tests are not re-entrant by default. We have this module installed, and our users do both type of RMA without problem, so I insist in a reproducible steps to reproduce the problem.

Ok then you can reproduce the error like this.
If you have rma_sale_mrp installed
create a rma with a qty > 1 for product which is not a kit product
Then do the incoming picking and after that create the refund
on the refund change the qty to a lower qty than it is set on the rma.
And then post the refund by calling action_post.
This should thrown an error because of this design

rma/rma/models/account_move.py

Line 30 in 50d86ae

def action_post(self):

But the error will not be thrown.

[pedrobaeza]

@chienandalu do you understand the problem? I don't.

[chienandalu]

Yes, I think is ok @pedrobaeza

@mt-software-de thanks for the fix :)

A comment on the method override design:

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[mt-software-de]

@chienandalu can you update your review and remove the stale label?

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-351-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at fa25e40. Thanks a lot for contributing to OCA. ❤️