Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] rma: improve rma report layout #440

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[IMP] rma: improve rma report layout #440

merged 1 commit into from
Jan 9, 2025

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Jan 8, 2025 •
edited
Loading

  • Use a table instead of a div.
  • Remove the move name, as it is not relevant to the customer and is redundant with the SO number and product reference.

Before
image
After
image

@OCA-git-bot
Copy link
Contributor

Hi @chienandalu, @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

Which is the before and a summary of the changes?

@sbejaoui
Copy link
Contributor Author

sbejaoui commented Jan 9, 2025

Which is the before and a summary of the changes?

I updated the PR description,

pedrobaeza
pedrobaeza approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may provoke problems with inherited modules extending the old report, but I don't think there should be many and it worths IMO.

chienandalu
chienandalu approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pedrobaeza
Copy link
Member

/ocabot merge minor

Please fw-port it if applicable.

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-440-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d97c6b3 into OCA:16.0 Jan 9, 2025
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fb4165b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbejaoui @OCA-git-bot @pedrobaeza @chienandalu