Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] sale_loyalty_initial_date_validity: New module #168

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[16.0][ADD] sale_loyalty_initial_date_validity: New module #168

merged 1 commit into from
Nov 15, 2023

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Oct 26, 2023 •
edited
Loading

@ernesto-garcia-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa please apply rebase and remove the test-requirements.txt file.

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_initial_date_validity branch 2 times, most recently from c0e2862 to aff481a Compare October 26, 2023 17:27
chienandalu
chienandalu suggested changes Oct 27, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

sale_loyalty_initial_date_validity/tests/test_sale_loyalty_initial_date_validity.py Show resolved Hide resolved
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_initial_date_validity branch 2 times, most recently from df24c6e to b8f191f Compare October 27, 2023 09:46
chienandalu
chienandalu approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_initial_date_validity branch from b8f191f to e2577cd Compare November 15, 2023 06:49
@pilarvargas-tecnativa
Copy link
Contributor Author

@CarlosRoca13 can you review please?

@chienandalu
Copy link
Member

CIs are red

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_initial_date_validity branch from e2577cd to e05aefe Compare November 15, 2023 08:38
@chienandalu
Copy link
Member

please @CarlosRoca13

CarlosRoca13
CarlosRoca13 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pilarvargas-tecnativa
Copy link
Contributor Author

ping @pedrobaeza :)

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 15, 2023
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-168-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6a82287 into OCA:16.0 Nov 15, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c62e767. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-sale_loyalty_initial_date_validity branch November 15, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pilarvargas-tecnativa @ernesto-garcia-tecnativa @chienandalu @OCA-git-bot @pedrobaeza @CarlosRoca13