Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] loyalty_partner_applicability: add configuration option #171

Merged

Conversation

pilarvargas-tecnativa
Copy link
Contributor

The option to allow sharing of coupons between members of the same trading entity in the settings must be in the base module.

cc @Tecnativa TT45413

@chienandalu @ernesto-garcia-tecnativa please review

Copy link
Contributor

@ernesto-garcia-tecnativa ernesto-garcia-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ok

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't you add the proper settings views?

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-loyalty_partner_applicability branch 2 times, most recently from ab0ded1 to 9544c8b Compare November 3, 2023 08:59
@pedrobaeza
Copy link
Member

Please use descriptive commit message. add configuration option is not descriptive. Which configuration option? Use instead (putting all the possible detail):

[IMP] loyalty_partner_applicability: Allow to share coupons inside same entity

There's a new configuration option in the settings to allow sharing coupons between members of the same trading entity.

It has to be in the base module for being shared between all the rest of applications, but each *_applicability module will contain extra bits of code to use it.

…me entity

There's a new configuration option in the settings to allow sharing
coupons between members of the same trading entity.

It has to be in the base module for being shared between all the rest of
applications, but each *_applicability module will contain extra bits of
code to use it.

TT45413
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-imp-loyalty_partner_applicability branch from 9544c8b to 1604d8e Compare November 3, 2023 12:29
@pilarvargas-tecnativa
Copy link
Contributor Author

Please use descriptive commit message. add configuration option is not descriptive. Which configuration option? Use instead (putting all the possible detail):

Thank you, I will improve my commits

@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-171-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6fa51ac into OCA:16.0 Nov 3, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7f83424. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-loyalty_partner_applicability branch November 3, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants