-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] loyalty_partner_applicability: add configuration option #171
[16.0][IMP] loyalty_partner_applicability: add configuration option #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't you add the proper settings views?
ab0ded1
to
9544c8b
Compare
Please use descriptive commit message.
|
…me entity There's a new configuration option in the settings to allow sharing coupons between members of the same trading entity. It has to be in the base module for being shared between all the rest of applications, but each *_applicability module will contain extra bits of code to use it. TT45413
9544c8b
to
1604d8e
Compare
Thank you, I will improve my commits |
/ocabot merge major |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 7f83424. Thanks a lot for contributing to OCA. ❤️ |
The option to allow sharing of coupons between members of the same trading entity in the settings must be in the base module.
cc @Tecnativa TT45413
@chienandalu @ernesto-garcia-tecnativa please review