Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] website_sale_coupon_selection_wizard>website_sale_loyalty_suggestion_wizard: Migration to version 16.0 #203

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[16.0][MIG] website_sale_coupon_selection_wizard>website_sale_loyalty_suggestion_wizard: Migration to version 16.0 #203

merged 6 commits into from
Dec 11, 2024

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Mar 5, 2024 •
edited
Loading

cc @Tecnativa TT44379

@chienandalu please review

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from f95c0a7 to ee0072c Compare March 5, 2024 17:36
@pedrobaeza
Copy link
Member

/ocabot migration website_sale_coupon_selection_wizard

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 5, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 5, 2024
Open
15 tasks
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch 3 times, most recently from f01d199 to 39e3048 Compare March 11, 2024 15:53
@pilarvargas-tecnativa pilarvargas-tecnativa marked this pull request as ready for review March 11, 2024 15:54
@pilarvargas-tecnativa
Copy link
Contributor Author

@chienandalu I think it should be renamed to website_sale_loyalty_order_suggestion, since the most direct dependency is to sale_loyalty_order_suggestion, what do you think about it?

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from 39e3048 to 1aa155e Compare March 11, 2024 16:40
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch 2 times, most recently from 401026a to 273d382 Compare March 15, 2024 10:56
@pilarvargas-tecnativa pilarvargas-tecnativa changed the title [16.0][MIG] website_sale_coupon_selection_wizard: Migration to version 16.0 [16.0][MIG] website_sale_coupon_selection_wizard>website_sale_loyalty_suggestion_wizard: Migration to version 16.0 Mar 15, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa mentioned this pull request Mar 15, 2024
Merged
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch 3 times, most recently from 28983c8 to 4aa8a29 Compare March 20, 2024 09:43
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from 4aa8a29 to 9cf8e8b Compare April 25, 2024 10:30
@pedrobaeza pedrobaeza requested a review from chienandalu July 11, 2024 10:55
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from 9cf8e8b to df6beeb Compare July 15, 2024 10:20
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from df6beeb to f82c7a0 Compare August 20, 2024 13:44
@pilarvargas-tecnativa
Copy link
Contributor Author

@carlos-lopez-tecnativa can you take a look please?

@carlos-lopez-tecnativa
Copy link

@carlos-lopez-tecnativa can you take a look please?

@pilarvargas-tecnativa The Runboat is pending. Could you please rebase the branch?

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from f82c7a0 to cd76c12 Compare November 21, 2024 15:20
@pilarvargas-tecnativa
Copy link
Contributor Author

@pilarvargas-tecnativa The Runboat is pending. Could you please rebase the branch?

Done!

chienandalu and others added 2 commits November 25, 2024 08:23
@chienandalu @pilarvargas-tecnativa
[MIG] website_sale_coupon_selection_wizard: Migration to 15.0
f724ef3 
TT39020
@Ivorra78 @pilarvargas-tecnativa
Translated using Weblate (Spanish)
9c23eb9 
Currently translated at 100.0% (9 of 9 strings)

Translation: sale-promotion-15.0/sale-promotion-15.0-website_sale_coupon_selection_wizard
Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-website_sale_coupon_selection_wizard/es/
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from cd76c12 to e3db5d1 Compare November 25, 2024 07:23
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch 2 times, most recently from e47da58 to d965853 Compare November 28, 2024 12:38
carlos-lopez-tecnativa
carlos-lopez-tecnativa suggested changes Nov 28, 2024
View reviewed changes
website_sale_loyalty_suggestion_wizard/templates/promotion_templates.xml
<a
role="button"
class="btn btn-info"
t-att-href="'/promotions/%s/apply' % promo.id"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is not working
image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last change I had deleted a necessary variable, it is now restored.

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from d965853 to 6c624da Compare November 28, 2024 14:38
carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Nov 28, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`

website_sale_loyalty_suggestion_wizard/templates/promotion_templates.xml Outdated Show resolved Hide resolved
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch 2 times, most recently from 6269722 to 365e9f0 Compare November 29, 2024 09:32
carlos-lopez-tecnativa
carlos-lopez-tecnativa reviewed Nov 29, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a new mismatch. Please let me know if this is an issue or expected behavior:

I created two rules: one for the Storage Box and another for the Large Cabinet.
Both products are displayed on the website.
Add both products to the cart.
Clear any applied promotions.
Apply the first promotion. The button to apply the promotion on the corresponding line becomes hidden, which is correct.
Remove the line with the applied promotion.
Apply the second promotion. However, the button to apply the promotion remains visible when it should be hidden, as it was for the first line.
If the user clicks the promotion button in this state, the URL is set to "False" (as mentioned in my previous comment) and results in a 404 error.

sale-promotion

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from 365e9f0 to d878385 Compare December 2, 2024 07:28
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-mig-website_sale_coupon_selection_wizard branch from d878385 to 9f50369 Compare December 2, 2024 07:31
@pilarvargas-tecnativa
Copy link
Contributor Author

I found a new mismatch. Please let me know if this is an issue or expected behavior:

Fixed, the error was causing that there is another promotion not published, before making the change to adapt the columns of the table that cell was conditioned to promo, when making the change to adapt the size of the table was missing add that condition to the cell of the icon.

carlos-lopez-tecnativa
carlos-lopez-tecnativa approved these changes Dec 2, 2024
View reviewed changes
Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality, LGTM.

@pedrobaeza
Copy link
Member

@chienandalu please confirm it's OK

chienandalu
chienandalu approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-203-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bacc701 into OCA:16.0 Dec 11, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dc079a9. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-website_sale_coupon_selection_wizard branch December 11, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-lopez-tecnativa carlos-lopez-tecnativa carlos-lopez-tecnativa approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pilarvargas-tecnativa @pedrobaeza @carlos-lopez-tecnativa @OCA-git-bot @chienandalu @Ivorra78