Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] sale_loyalty_order_suggestion_multi_gift: New module #206

Conversation

pilarvargas-tecnativa
Copy link
Contributor

@pilarvargas-tecnativa pilarvargas-tecnativa commented Mar 15, 2024

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_gift branch from 7cf1cb3 to 18d09a3 Compare March 20, 2024 09:47
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_gift branch from 18d09a3 to cd12478 Compare April 25, 2024 10:14
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 12, 2024
@pedrobaeza pedrobaeza requested a review from chienandalu July 12, 2024 18:42
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
@pilarvargas-tecnativa
Copy link
Contributor Author

ping @chienandalu

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 17, 2024
@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_gift branch from cd12478 to e12b3fa Compare November 18, 2024 06:50
@pedrobaeza pedrobaeza requested review from chienandalu and removed request for chienandalu November 18, 2024 07:46
@carlos-lopez-tecnativa
Copy link

I tested this, but I’m not sure if it’s working correctly.
My settings:

image
image
Despite these settings, I didn’t see the button on the sale order line
Could you confirm if this is the expected behavior?

image

@pilarvargas-tecnativa
Copy link
Contributor Author

I tested this, but I’m not sure if it’s working correctly. My settings:

From the local tests I have done, it is possible that there is a conflict with one of the other installed modules. Some of them need bridging modules. I will look into it. If you test without setting a product in the rules it does suggest the promotion correctly. When you set the product it should also suggest the promotion and in fact in my local tests it does, I will investigate which module causes the conflict and if necessary resolve it. Thanks

@pilarvargas-tecnativa pilarvargas-tecnativa force-pushed the 16.0-add-sale_loyalty_order_suggestion_multi_gift branch from e12b3fa to fdfce0c Compare November 20, 2024 06:46
@pilarvargas-tecnativa
Copy link
Contributor Author

@carlos-lopez-tecnativa You can check again

Copy link

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally tested, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-206-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cea5fc6 into OCA:16.0 Nov 20, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0e1d75f. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-add-sale_loyalty_order_suggestion_multi_gift branch November 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants