-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] sale_loyalty_order_suggestion_multi_gift: New module #206
[16.0][ADD] sale_loyalty_order_suggestion_multi_gift: New module #206
Conversation
7cf1cb3
to
18d09a3
Compare
18d09a3
to
cd12478
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
ping @chienandalu |
cd12478
to
e12b3fa
Compare
From the local tests I have done, it is possible that there is a conflict with one of the other installed modules. Some of them need bridging modules. I will look into it. If you test without setting a product in the rules it does suggest the promotion correctly. When you set the product it should also suggest the promotion and in fact in my local tests it does, I will investigate which module causes the conflict and if necessary resolve it. Thanks |
e12b3fa
to
fdfce0c
Compare
@carlos-lopez-tecnativa You can check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally tested, LGTM
This PR has the |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 0e1d75f. Thanks a lot for contributing to OCA. ❤️ |
Pending from:
cc @Tecnativa TT48349
@chienandalu please review