[17.0][MIG] sale_pricelist_global_rule: Migration to version 17.0 #3526
+2,077
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quantities across sales order lines - by product template - by product category
…onstraint conflicts The `product_variant_default_code` module adds a unique constraint, which causes test failures when installed alongside `sale_pricelist_global_rule`. This fix adjusts the tests in to avoid conflicts with this unique constraint, ensuring compatibility when both modules are installed.
If not, we get:
```
Traceback (most recent call last):
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 658, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/custom/src/odoo/odoo/http.py", line 301, in _handle_exception
raise exception.with_traceback(None) from new_cause
psycopg2.errors.DatatypeMismatch: ARRAY types integer and boolean cannot be matched
LINE 9: ...L OR item.global_product_tmpl_id = any(ARRAY[false,...
```
A little refactor for better code in the method is also done.
TT51677
…putes complementary to commit 637c766
- Reused Odoo's base code for computing pricelists, adapted it to new functions, and simplified the logic. - Renamed selection options for the applied_on field: 4_global_product_template to 3_1_global_product_template and 5_global_product_category to 3_2_global_product_category to ensure the correct order in pricelist items. - Fixed an assertion in the tests. Previously, changing the UoM did not update the price, but this behavior was introduced in PR OCA#2473. - Added a new assertion for the pricelist_item_id field.
|
CI is red |
|
/ocabot migration sale_pricelist_global_rule |
Issue introduced in OCA#3150
…tential related errors in other addons.
carlos-lopez-tecnativa
force-pushed
the
17.0-mig-sale_pricelist_global_rule
branch
from
5c871a9 to
58dcdfe
Compare
I found an issue in this PR: OCA/sale-workflow#3150. Please let me know if it’s okay to add this commit to the current PR or if I should create a new, independent PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applied_onfield:4_global_product_templateto3_1_global_product_templateand5_global_product_categoryto3_2_global_product_categoryto ensure the correct order in pricelist items.pricelist_item_idfield.TT52357
@Tecnativa @pedrobaeza @victoralmau could you please review this.