Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action for make all #292

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

stweil
Copy link
Collaborator

@stweil stweil commented Mar 7, 2022

It is currently configured to be triggered manually either from the
GitHub web frontend or from the GitHub API.

make all can be run with a selected version of Ubuntu and Python,
or a matrix of versions.

Signed-off-by: Stefan Weil [email protected]

It is currently configured to be triggered manually either from the
GitHub web frontend or from the GitHub API.

`make all` can be run with a selected version of Ubuntu and Python,
or a matrix of versions.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Collaborator Author

stweil commented Mar 7, 2022

As soon as this PR was merged, we can run our first GitHub action for the full matrix of
[ubuntu-18.04, ubuntu-20.04] x [Python 3.6, 3.7, 3.8, 3.9, 3.10] (10 runs).

For both versions of Ubuntu, Python 3.6 and 3.7 (and 3.8 with PR #289) should build fine, while the other Python versions are expected to abort when trying to get Tensorflow 1.5.

@stweil
Copy link
Collaborator Author

stweil commented Mar 7, 2022

Example of GitHub action with full test matrix: https://github.com/stweil/ocrd_all/actions/runs/1947808212.

Even with PR #289, only Python 3.6 builds all targets. Python 3.7 and 3.8 fail when building cor-asv-ann-check.

@bertsky
Copy link
Collaborator

bertsky commented Mar 7, 2022

Even with PR #289, only Python 3.6 builds all targets. Python 3.7 and 3.8 fail when building cor-asv-ann-check.

That seems to be coming from new upstream conflicts between Tensorflow and Scikit-Image. We recently encountered that in ocrd_pc_segmentation, but it seems to be wider. Needs to be investigated.

@stweil stweil merged commit 196716b into OCR-D:master Mar 9, 2022
@stweil stweil deleted the github-action branch March 9, 2022 21:23
@stweil
Copy link
Collaborator Author

stweil commented Mar 9, 2022

I rebased and merged my latest pull requests and started now the first GitHub action for OCR-D/ocrd_all with the full build matrix: https://github.com/OCR-D/ocrd_all/actions/runs/1959782165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants