-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 release candidate #42
Conversation
Migrate from travis ci to github actions
Explicitly import external class definitions and add code coverage to github actions
…develop/EvidenceSynthesis.
Change package maintainer to Adam Black and update github actions yaml, compare_versions, and deploy.sh
* Add native date and datetime support. * Add hms to Imports. Needed for dates in RSQLite. Co-authored-by: Adam Black <[email protected]>
Change broken link to pdf vignette to html vignette.
…olumn names. Add tests for new methods.
…iffer only by case. Prior implementation changed table order.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 89.21% 82.44% -6.78%
==========================================
Files 4 3 -1
Lines 371 262 -109
==========================================
- Hits 331 216 -115
- Misses 40 46 +6
☔ View full report in Codecov by Sentry. |
…eda tables. try to delete locked files later.
I've made the changes we discussed in the call today. I also added some code to try and handle the windows file lock issue. Not sure how to test it because it is kind of a random thing and I have no way to know when the lock is released if ever. But maybe it will help. Each time I don't know what to do about the upcoming changes to pull except maybe to complain to the Arrow folks. Otherwise we can just ask users to set an option. We could check the option on startup and print a message. One thing I wanted to ask about since this is a big change. I'd like to consider moving dplyr from Depends to Imports. The reason is that I'm exporting a lot (all of dplyr), some of which has nothing to do with Andromeda or doesn't work on Andromeda. What if we asked users to load dplyr if they want it? Or possibly just re-export a smaller subset of dplyr functions? |
Would it be possible to do a small release first that introduces the As for |
Yes I did create a release with
Ok. I think I might try moving it to Imports and only export the dplyr functions supported by Andromeda (select, mutate, etc). |
* Using ParallelLogger's JSON functions to store attributes. Fixes #54 * Dropping jsonlite from DESCRIPTION --------- Co-authored-by: Admin_mschuemi <[email protected]>
This release candidate switches the Andromeda backend from SQLite to Apache Arrow. It is not technically a breaking change but due to slight differences in how SQLite tables and arrow tables are handled it can't be released until it is tested with all reverse dependencies.
Addresses