Update to v12.7.0

CHANGELOG.md

@@ -1,5 +1,90 @@
 # Change log
 
+## Version 12.7.0
+
+### General portal changes
+
+* Using the latest version of the Facebook API without specifying a version number. Previously, version 2.7 was used, which is outdated.
+* Added Zoom login provider.
+* Added the mysql port setting in the UrlShortener service config.
+* Added methods for getting entities in parts and sorting by id.
+* Fixed the dark theme issues: the deeplink dialog window for opening a file on mobile devices; the "On top" button in entity lists on a narrow screen; the letter container in the Mail module; the dialog window for mentioning a user via @ in ckeditor.
+* Removed font styles when pasting text from MS Word to ckeditor.
+* Disabled Facebook until the application is validated.
+* Disabled Google Drive until the application is validated.
+* Increased the length of the short link.
+* Fixed the issue with indicating an incorrect maximum number of characters in the hint. TenantDomainValidator: A subdomain can be up to 255 characters long, but if you have multiple levels in your subdomain, each level can only be 63 characters long (Bug 66512).
+* Fixed the issue when the /ajaxpro/ASC.Web.Studio.UserControls.Common.PollForm.PollForm,ASC.Web.Studio.ashx method allows voting through BS Turbo Intruder multiple times (Bug 66500).
+* Fixed the issue when the api/2.0/settings/customnavigation/getall method is available to users without administrator rights (Bug 66647).
+* Fixed errors in the Favorites folder after changing the settings for connecting a third-party storage, if its file was added to Favorites. (Bug 66624).
+* Fixed issue when the /api/2.0/settings/security method is available to users without administrator rights. (Bug 66663).
+* Fixed the issue with missing backend validation for the Success probability. (Bug 66667).
+* Fixed the typo in the link to the Organization profile page (?type=organisation_profile). (Bug 66715).
+* Fixed the issue when the /api/2.0/settings/security/loginSettings method allows seting values ​​of more than 4 characters for Brute Force Protection in Workspace. (Bug 66756).
+* Fixed the issue when the /ajaxpro/ASP.usercontrols_management_cookiesettings_cookiesettings_ascx,ASC.ashx method allows setting a value of more than 4 characters for Session Lifetime in Workspace. (Bug 66709).
+* Fixed the "Could not resolve current tenant" error when exporting a large number of contacts. (Bug 62984).
+* Fixed the issue when contact avatars are available via direct link when access is closed for the user. (Bug 66708).
+* Fixed the issue when the /fckuploader method allows users without access to the Community module to upload images. (Bug 66710).
+* Fixed the issue when a user without access to the mail server can use the mailserver/domains/common method. (Bug 67100).
+* Fixed the translation of the Unblock/Check-in button in Chinese. (Bug 67464).
+* Fixed the issue when the /ajaxpro/ASC.Web.Studio.UserControls.Common.PollForm.PollForm,ASC.Web.Studio.ashx method allows a user with limited access to the Community module to vote. (Bug 67465).
+* Fixed the issue with the white background of a document title on the Deeplink page with the dark interface theme. (Bug 67529).
+* Fixed the issue with the "index was outside the bounds of the array" error when generating reports. (Bug 67986).
+* Added a loader in the manager when saving .docxf via Save as PDF form. (Bug 66529).
+* Fixed the issue when a user without administrator rights can download the backup file via a direct link. (Bug 68162).
+* Switched FFmpeg-installer to use pre-downloaded file. (Bug 67421).
+* Updated MySQL to v8.0.37. (Bug 68348).
+* Fixed the issue with missing the Save as PDF form button in the context menu of the .oform file. (Bug 68646).
+* Fixed the issue when the /app/onlyoffice/CommunityServer/data/Products/Files/00/00/01/temp/ folder is added to the backup file. (Bug 68392).
+* Fixed the issue when the value "undefined" appears in the URL after selecting yourself as a responsible for a project. (Bug 68942).
+* Fixed the issue when the /api/2.0/portal/usedspace method is available to users without administrator rights in Worksapce. (Bug 68990).
+* Fixed the issue with the advanced sorting list button in the Recent folder. (Bug 68707).
+* Fixed the issue with missing the link to download the temporary Backup file after refreshing the page. (Bug 67877).
+* Fixed the issue with upgrading Workspace to Enterprise Edition (Bug 68561).
+* Fixed the issue with null values ​​of imported data in a link to a third-party resource instead of a warning. (Bug 69914).
+* Fixed the issue when the link to change email remains active after sending a message to change email to another address. (Bug 68836).
+* Fixed the issue when the file list does not scroll when selecting with the left mouse button held down. (Bug 68654).
+* Replaced Twitter icon with actual X icon. (Bug 70255).
+* Fixed the issue when files without an extension are not included in the backup archive. (Bug 70294).
+* Fixed the "DOMNodeInserted" error while creating message. (Bug 70295).
+* Fixed hanging the Mail module when changing the number of displayed letters /page_size=1000/. (Bug 68786).
+* Fixed the issue when documents are not available after performing restore. (Bug 70348).
+* Fixed the issue when the POST /api/2.0/settings/rebranding/company method allows passing to the About window the email and website addresses using punycode. (Bug 70257).
+* Fixed the issue when the /api/2.0/settings/tfaappcodes method allows viewing Backup codes after disabling two-factor authentication in Workspace. (Bug 70390).
+* Fixed the issue when the PUT /api/2.0/portal/portalrename method allows renaming a portal with a space before the name. (Bug 70391).
+* Fixed the issue with the Enterprise Edition license. (Bug 70051).
+* Fixed the issue when the /api/2.0/portal/getshortenlink method allows substituting a malicious site into the shortlink. (Bug 70392).
+* Fixed the issue when the PUT /api/2.0/people/{ID} method allows allows changing a type of a deactivated user. (Bug 70395).
+* Fixed the issue when the api/2.0/group/{groupid}/manager method allows assigning a blocked user as a group manager. (Bug 70418).
+* Fixed the issue with a timeout expected when entering an incorrect login/password for the mail/gmail mailbox. (Bug 68740).
+* Fixed the issue when marking a To-do task as completed or uncompleted changes its start time (DTSTART label). (Bug 68970).
+* Fixed the issue with missing logos of the social network (X) Twitter in the dark theme of the portal. (Bug 70457).
+
+### Documents module
+
+* Updated the list of the editors error codes.
+* The djvu, oxps, pdf, xps formats will be sent to the editor with the documentType=pdf  indication (editor 8.0 or higher is required). The docxf and oform formats will be sent to the editor with the documentType=pdf indication (editor 8.1 or higher is required).
+* The Protected panel is hidden for the anonymous so that he cannot set a password for the file.
+* When sharing via an external link for viewing, the chat is not available and the username is not requested.
+* User avatars are transferred to the editor for authorized users if there is access to the People module.
+* In a mobile browser, when opening the editor, the ONLYOFFICE logo will not be displayed if the license allows (editor 8.1 or higher is required).
+* Files in djvu and oform formats can be converted to pdf (editor 7.1 or higher is required).
+* When creating a form, an empty PDF form file will be opened for editing. In the context menu of any PDF file there are the following buttons: edit (the mode as for docxf with changing all contents and saving), fill in (the mode as for oform with filling in fields and saving) and view (the mode of opening for viewing with the ability to fill in without saving) (editor 8.1 or higher is required). The document manager does not distinguish a PDF file from our PDF form.
+* For the docxf file, the "Save as PDF form" button is kept in the context menu. A similar button is added to the context menu of the oform file.
+* Creating a PDF form from docx works through conversion, editor 8.1 or higher is required.
+* Support for referencing a portal file in a spreadsheet in the IMPORTRANGE formula (editor 8.1 or higher is required).
+* Added the sr-Cyrl-RS empty file.
+* Updated empty file templates in English.
+* Added the version parameter to GetPresignedUri.
+* Added the shardkey parameter for requests to editors.
+
+### Control Panel
+
+* Fixed the issue with missing the link to download the temporary Backup file after refreshing the page. (Bug 70341).
+* Fixed the issue when a curl request to the Control Panel stops the service on Windows. (Bug 70049).
+* Fixed the issue when the description of the dark theme logo indicates that the logo is for the light theme. (Bug 68858).
+* Added a checkbox when creating a backup for migration to DocSpace. 
+
 ## Version 12.6.0
 
 ### General portal changes

build/install/deb/debian/postinst

@@ -263,7 +263,7 @@ case "$1" in
 		rm -f /etc/nginx/sites-enabled/{{package_sysname}}-apisystem
 
 		# disable apparmor mysql. need for best perfomance mysql
-		if which apparmor_parser && [ ! -f /etc/apparmor.d/disable/usr.sbin.mysqld ]; then
+		if which apparmor_parser && [ ! -f /etc/apparmor.d/disable/usr.sbin.mysqld ] && [ -f /etc/apparmor.d/disable/ ]; then
 			ln -sf /etc/apparmor.d/usr.sbin.mysqld /etc/apparmor.d/disable/
 			apparmor_parser -R /etc/apparmor.d/usr.sbin.mysqld || true
 		fi
@@ -283,13 +283,13 @@ END
 		[ -f /usr/lib/python3.$(python3 -c 'import sys; print(sys.version_info.minor)')/EXTERNALLY-MANAGED ] && \
 		rm /usr/lib/python3.$(python3 -c 'import sys; print(sys.version_info.minor)')/EXTERNALLY-MANAGED
 
-		python3 -m pip install --upgrade pip
-		python3 -m pip install --upgrade requests
-		python3 -m pip install --upgrade setuptools 
-		python3 -m pip install --upgrade radicale==3.0.5
-		python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_auth_plugin/.
-		python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_store_plugin/.
-		python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_rights_plugin/.
+		for pkg in radicale==3.0.5 requests setuptools importlib_metadata; do
+			dpkg -l python3-"${pkg%%=*}" &>/dev/null || pip_packages+=("$pkg")
+		done
+
+		export PIP_ROOT_USER_ACTION=ignore
+		python3 -m pip install --upgrade "${pip_packages[@]}" \
+			"$DIR/Tools/radicale/plugins/"{app_auth_plugin,app_store_plugin,app_rights_plugin}/. || true
 
         #configure elasticsearch
         service elasticsearch stop
@@ -452,7 +452,7 @@ EOF
 			sed '/web\.controlpanel\.url/s/\(value\s*=\s*\"\)[^\"]*\"/\1\/controlpanel\/\"/' -i  ${APP_ROOT_DIR}/web.appsettings.config;
 			sed '/web\.controlpanel\.url/s/\(value\s*=\s*\"\)[^\"]*\"/\1\/controlpanel\/\"/' -i ${APP_SERVICES_DIR}/TeamLabSvc/TeamLabSvc.exe.config;
 
-			if systemctl is-active {{package_sysname}}ControlPanel | grep -q ^active; then
+			if systemctl is-active {{package_sysname}}ControlPanel &>/dev/null; then
 				service {{package_sysname}}ControlPanel restart >/dev/null 2>&1
 			fi
 		fi
@@ -522,7 +522,7 @@ CipherString = $CIPHERSTRING \n" >> $OPENSSL_CONF
 		service nginx restart >/dev/null 2>&1
 		service mysql restart >/dev/null 2>&1 || true # ignore errors
 
-		if systemctl is-active monoserve | grep -q "active"; then
+		if systemctl is-active monoserve &>/dev/null; then
 			curl --silent --output /dev/null http://127.0.0.1/api/2.0/warmup/restart.json || true
 		fi		
 

build/install/rpm/common.spec

@@ -111,7 +111,7 @@ IFS="$OLD_IFS"
 rm -rf "$RPM_BUILD_ROOT"
 
 %files -f onlyoffice.list
-%attr(-, root, root) /usr/bin/*.sh
+%attr(744, root, root) /usr/bin/*.sh
 %attr(-, %{package_sysname}, %{package_sysname}) %dir /var/log/%{package_sysname}/
 %attr(-, root, root) /usr/lib/systemd/system/*.service
 %attr(-, root, root) %{nginx_conf_d}/%{package_sysname}.conf
@@ -160,7 +160,7 @@ find "$DIR/controlpanel/www/config" -type f -name "*.json" -exec sed -i "s_\(\"c
 package_services=("monoserve" "%{package_sysname}ControlPanel")
 
 for SVC in "${package_services[@]}"; do
-    if systemctl is-active "$SVC" | grep -q ^active; then
+    if systemctl is-active "$SVC" &>/dev/null; then
         systemctl restart "$SVC"
     fi
 done
@@ -175,12 +175,13 @@ fi
 
 DIR="/var/www/%{package_sysname}"
 
-python3 -m pip install --upgrade pip
-python3 -m pip install --upgrade requests
-python3 -m pip install --upgrade radicale==3.0.5
-python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_auth_plugin/.
-python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_store_plugin/.
-python3 -m pip install --upgrade $DIR/Tools/radicale/plugins/app_rights_plugin/.
+for pkg in radicale==3.0.5 requests setuptools importlib_metadata; do
+    rpm -q python3-"${pkg%%=*}" &>/dev/null || pip_packages+=("$pkg")
+done
+
+export PIP_ROOT_USER_ACTION=ignore
+python3 -m pip install --upgrade "${pip_packages[@]}" \
+    "$DIR/Tools/radicale/plugins/"{app_auth_plugin,app_store_plugin,app_rights_plugin}/. || true
 
 systemctl restart %{package_sysname}Radicale
 
@@ -191,7 +192,7 @@ APP_ROOT_DIR="$DIR/WebStudio";
 
 sed '/web\.talk/s/value=\"\S*\"/value=\"true\"/g' -i  ${APP_ROOT_DIR}/web.appsettings.config
 
-if systemctl is-active monoserve | grep -q "active"; then
+if systemctl is-active monoserve &>/dev/null; then
 	systemctl restart monoserve
 fi
 
@@ -256,7 +257,7 @@ fi
 
 for SVC in monoserve %{package_sysname}Thumb %{package_sysname}ThumbnailBuilder
 do
-	if systemctl is-active $SVC | grep -q "active"; then
+	if systemctl is-active $SVC &>/dev/null; then
 		systemctl restart $SVC
 	fi
 done
@@ -310,7 +311,7 @@ APP_INDEX_DIR="${APP_DATA_DIR}/Index/v${ELASTIC_SEARCH_VERSION}"
 LOG_DIR="/var/log/%{package_sysname}"
 
 #import common ssl certificates
-mozroots --import --sync --machine --quiet
+mozroots --import --sync --machine --quiet || cert-sync /etc/pki/tls/certs/ca-bundle.crt || true
 mkdir -p /etc/mono/registry/LocalMachine
 mkdir -p /usr/share/.mono/keypairs
 mkdir -p /var/cache/nginx/%{package_sysname}
@@ -368,15 +369,12 @@ if [ $1 -ge 2 ]; then
 	fi
 fi
 
-if [ $1 -eq 1 ]; then
-
-	if /usr/share/elasticsearch/bin/elasticsearch-plugin list | grep -q "ingest-attachment"; then
-		/usr/share/elasticsearch/bin/elasticsearch-plugin remove ingest-attachment
-	fi
-
-	/usr/share/elasticsearch/bin/elasticsearch-plugin install -s -b ingest-attachment	
+if /usr/share/elasticsearch/bin/elasticsearch-plugin list | grep -q "ingest-attachment"; then
+	/usr/share/elasticsearch/bin/elasticsearch-plugin remove ingest-attachment
 fi
 
+/usr/share/elasticsearch/bin/elasticsearch-plugin install -s -b ingest-attachment
+
 if [ -f ${ELASTIC_SEARCH_CONF_PATH}.rpmnew ]; then
    cp -rf ${ELASTIC_SEARCH_CONF_PATH}.rpmnew ${ELASTIC_SEARCH_CONF_PATH};   
 fi
@@ -454,7 +452,7 @@ if [ -d /etc/elasticsearch/ ]; then
 	chmod g+ws /etc/elasticsearch/
 fi
 
-if systemctl is-active elasticsearch | grep -q "active"; then
+if systemctl is-active elasticsearch &>/dev/null; then
 	#Checking that the elastic is not currently being updated
 	if [[ $(find /usr/share/elasticsearch/lib/ -name "elasticsearch-[0-9]*.jar" | wc -l) -eq 1 ]]; then
 		systemctl restart elasticsearch.service
@@ -506,13 +504,13 @@ if [ $1 -ge 2 ]; then
 			systemctl restart $SVC
 		fi
 	done
-	if systemctl is-active %{package_sysname}AutoCleanUp | grep -q "active"; then
+	if systemctl is-active %{package_sysname}AutoCleanUp &>/dev/null; then
 		systemctl disable %{package_sysname}AutoCleanUp
 		systemctl stop %{package_sysname}AutoCleanUp
 	fi
 fi
 
-if systemctl is-active monoserve | grep -q "active"; then
+if systemctl is-active monoserve &>/dev/null; then
 	curl --silent --output /dev/null http://127.0.0.1/api/2.0/warmup/restart.json || true
 fi		
 
@@ -549,11 +547,11 @@ if [ ! -z $ELASTIC_SEARCH_VERSION ]; then
 
 	$DIR/elasticsearch-plugin install -s -b ingest-attachment	
 
-	if ! systemctl is-active elasticsearch | grep -q "inactive"; then
+	if systemctl is-active elasticsearch &>/dev/null; then
 		systemctl restart elasticsearch 
 	fi
 
-	if ! systemctl is-active %{package_sysname}Index | grep -q "inactive"; then
+	if systemctl is-active %{package_sysname}Index &>/dev/null; then
 		systemctl restart %{package_sysname}Index 
 	fi
 fi

build/sql/onlyoffice.data.sql

@@ -239,6 +239,7 @@ BEGIN
 	insert into files_converts (input, output) values ('.csv', '.xlsx');
 	insert into files_converts (input, output) values ('.csv', '.xltm');
 	insert into files_converts (input, output) values ('.csv', '.xltx');
+	insert into files_converts (input, output) values ('.djvu', '.pdf');
 	insert into files_converts (input, output) values ('.doc', '.docm');
 	insert into files_converts (input, output) values ('.doc', '.docx');
 	insert into files_converts (input, output) values ('.doc', '.dotm');
@@ -494,6 +495,7 @@ BEGIN
 	insert into files_converts (input, output) values ('.odt', '.pdf');
 	insert into files_converts (input, output) values ('.odt', '.rtf');
 	insert into files_converts (input, output) values ('.odt', '.txt');
+	insert into files_converts (input, output) values ('.oform', '.pdf');
 	insert into files_converts (input, output) values ('.ott', '.docm');
 	insert into files_converts (input, output) values ('.ott', '.docx');
 	insert into files_converts (input, output) values ('.ott', '.dotm');

build/sql/onlyoffice.sql

@@ -2464,7 +2464,7 @@ CREATE TABLE IF NOT EXISTS `wiki_pages_history` (
 ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
 
 CREATE TABLE IF NOT EXISTS `short_links` (
-  `id` INT(21) NOT NULL AUTO_INCREMENT,
+  `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT,
   `short` VARCHAR(12) COLLATE utf8_bin NULL DEFAULT NULL,
   `link` TEXT NULL,
   PRIMARY KEY (`id`),

build/sql/onlyoffice.upgradev127.sql

@@ -0,0 +1,19 @@
+DELIMITER DLM00
+
+DROP PROCEDURE IF EXISTS upgrade127 DLM00
+
+CREATE PROCEDURE upgrade127()
+BEGIN
+
+    INSERT IGNORE INTO `files_converts` (`input`, `output`) VALUES ('.djvu', '.pdf');
+    INSERT IGNORE INTO `files_converts` (`input`, `output`) VALUES ('.oform', '.pdf');
+
+    DELETE FROM `files_converts` WHERE `output`='.docxf';
+
+    ALTER TABLE `short_links` CHANGE COLUMN `id` `id` BIGINT(20) UNSIGNED NOT NULL AUTO_INCREMENT;
+
+END DLM00
+
+CALL upgrade127() DLM00
+
+DELIMITER ;

common/ASC.Core.Common/ASC.Core.Common.csproj

@@ -83,6 +83,7 @@
     <Compile Include="Core\PartnerStatus.cs" />
     <Compile Include="Core\PartnerType.cs" />
     <Compile Include="Core\DBResourceManager.cs" />
+    <Compile Include="Core\StringExtension.cs" />
     <Compile Include="Data\DbLoginEventsManager.cs" />
     <Compile Include="Data\DbSettingsManager.cs" />
     <Compile Include="Encryption\EncryprtionStatus.cs" />

common/ASC.Core.Common/Contracts/BackupServiceModel.cs

@@ -57,6 +57,9 @@ public class StartBackupRequest
 
         [DataMember]
         public Dictionary<string, string> StorageParams { get; set; }
+
+        [DataMember]
+        public bool Dump { get; set; }
     }
 
     [DataContract]