Merge pull request #317 from ONLYOFFICE/feature/fix-linter

Feature/fix linter
ONLYOFFICE · Dec 1, 2022 · f7bb668 · f7bb668
2 parents e9721dd + 808712a
commit f7bb668
Show file tree

Hide file tree

Showing 8 changed files with 3,472 additions and 159 deletions.
diff --git a/.github/workflows/lint-python.yml b/.github/workflows/lint-python.yml
@@ -17,11 +17,12 @@ jobs:
         working-directory: ./web/documentserver-example/python
     steps:
       - uses: actions/checkout@v3
+
       - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v4
         with:
-          python-version: 3.6.9
-      
+          python-version: '3.10' 
+
       - name: Install Dependencies
         run: |
           python -m pip install --upgrade pip
@@ -36,4 +37,4 @@ jobs:
           
       - name: Lint Pylint
         run: |
-          pylint ./**/*.py
+          pylint ./**/*.py
diff --git a/.github/workflows/lint-ruby.yml b/.github/workflows/lint-ruby.yml
@@ -1,4 +1,4 @@
-name: RuboCop Linter
+name: Rubocop
 
 on:
   workflow_dispatch:
@@ -18,8 +18,14 @@ jobs:
     steps:
       - name: Checkout Repository
         uses: actions/checkout@v3
-
-      - name: RuboCop Linter Action
-        uses: andrewmcodes/[email protected]
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.0'
+          bundler-cache: true
+      - name: Install dependencies
+        run: | 
+          bundle install
+      - name: Rubocop
+        run: |
+          gem install rubocop
+          rubocop
diff --git a/web/documentserver-example/java-spring/pom.xml b/web/documentserver-example/java-spring/pom.xml
@@ -83,6 +83,31 @@
 				<groupId>org.springframework.boot</groupId>
 				<artifactId>spring-boot-maven-plugin</artifactId>
 			</plugin>
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>2.17</version>
+				<executions>
+					<execution>
+						<id>validate</id>
+						<phase>validate</phase>
+						<configuration>
+							<configLocation>google_checks.xml</configLocation>
+							<encoding>UTF-8</encoding>
+							<failsOnError>true</failsOnError>
+							<failOnViolation>true</failOnViolation>
+							<logViolationsToConsole>true</logViolationsToConsole>
+							<violationSeverity>warning</violationSeverity>
+							<consoleOutput>true</consoleOutput>
+							<includeTestSourceDirectory>true
+							</includeTestSourceDirectory>
+						</configuration>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>
 </project>
diff --git a/web/documentserver-example/java/pom.xml b/web/documentserver-example/java/pom.xml
@@ -85,6 +85,31 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>2.17</version>
+				<executions>
+					<execution>
+						<id>validate</id>
+						<phase>validate</phase>
+						<configuration>
+							<configLocation>google_checks.xml</configLocation>
+							<encoding>UTF-8</encoding>
+							<failsOnError>true</failsOnError>
+							<failOnViolation>true</failOnViolation>
+							<logViolationsToConsole>true</logViolationsToConsole>
+							<violationSeverity>warning</violationSeverity>
+							<consoleOutput>true</consoleOutput>
+							<includeTestSourceDirectory>true
+							</includeTestSourceDirectory>
+						</configuration>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
         </plugins>
     </build>
 

diff --git a/web/documentserver-example/nodejs/.eslintignore b/web/documentserver-example/nodejs/.eslintignore
@@ -0,0 +1 @@
+public
diff --git a/web/documentserver-example/nodejs/.eslintrc.js b/web/documentserver-example/nodejs/.eslintrc.js
@@ -0,0 +1,15 @@
+module.exports = {
+  env: {
+    browser: true,
+    commonjs: true,
+    es2021: true,
+  },
+  extends: ['airbnb-base'],
+  overrides: [
+  ],
+  parserOptions: {
+    ecmaVersion: 'latest',
+  },
+  rules: {
+  },
+};