Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last updates before 1.10 #762

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Last updates before 1.10 #762

merged 7 commits into from
Nov 15, 2023

Conversation

bertrand-lorentz
Copy link
Contributor

No description provided.

@bertrand-lorentz bertrand-lorentz requested review from pdonohoe and a user November 15, 2023 10:45
@bertrand-lorentz bertrand-lorentz merged commit ebf17b3 into develop Nov 15, 2023
2 checks passed
@bertrand-lorentz bertrand-lorentz deleted the updates-before-1.10 branch November 15, 2023 12:53
Copy link
Contributor

@pdonohoe pdonohoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All EFX changes are good, except for summary.efx. It is partly my fault, but it has been completely messed up. Is there any way to keep the existing summary.efx / not implement the changes for this file? Thanks

@bertrand-lorentz
Copy link
Contributor Author

All EFX changes are good, except for summary.efx. It is partly my fault, but it has been completely messed up. Is there any way to keep the existing summary.efx / not implement the changes for this file? Thanks

That comment came after the PR was merged. Any fixes we want to do for 1.10.0 will have to be done in PR #763

@pdonohoe
Copy link
Contributor

OK thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants