Various updates in generated files #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update corresponding schematron rules, and affected validation reports.
In Schematron, phase identifiers should not start with a digit, so add the prefix "eforms-" to all phase identifiers: "eforms-16". So when executing the schematron, you must also add this prefix when you specify the phase to execute based on the notice subtype.
Also update corresponding schematron rules.
Also update corresponding Schematron rules.
Also add corresponding Schematron.
Values should be unique in the group of lots, not across the whole notice. This is not supported currently, so remove the assert. Also remove from Schematron rules.
Winner Decision (BT-1451) can be on the same day the notice is submitted (BT-05) and the contract is signed (BT-145). Also update corresponding Schematron rules.
Also update corresponding schematron rules.
Also update corresponding Schematron rules.
The fields BT-22-Lot and BT-22-LotsGroup are now optional.
Also update validation reports.
Add rules to check that fields that contain structured values (id, code) do not have leading or trailing whitespace. Update affected validation reports. See also discussion #779.
The country codelist now has the same content as eforms-country, so we don't need this tailored codelist anymore. Also update references to this codelist in fields.json.
CPV codes had no translations in Croatian, as they are not in the source used. Add those translations in the corresponding codelists files, and in the translation file code_hr.xml.
Change constraints to allow change notices with "cancel-intent" to be submitted after the tender deadline has passed.
For asserts that calculate a sum of several values, do not require a strict equality but allow some approximation. This is to avoid validation failures when some values have been rounded up or down.
The RELAX NG schema in the Schematron SIO standard requires some elements to be in a certain order: title, ns, etc. Move a few elments to avoid any errors when validating against this schema. This has no effect on the execution of the Schematron, implementations seems less strict than the schema.
Making a GET request to search for a notice is not possible with the new TED website, as it supports only POST requests. So remove the rule that makes this request, to avoid pointless requests and slient errors.
rouschr
reviewed
Feb 5, 2024
YvesJo
approved these changes
Feb 5, 2024
Any changes since the commits in this PR will be reflect in future commits/PR. |
pdonohoe
approved these changes
Feb 5, 2024
rouschr
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of updates for SDK 1.11, in most of the generated files.
Please see the individual commits.
The failure of the SDK Analyzer is due to invalid characters in translations texts. Correction for this is in progress.