Fix Ethernet/IP writes.

OPCFoundation · Oct 6, 2024 · cad17a9 · cad17a9
1 parent 220bcee
commit cad17a9
Showing 1 changed file with 36 additions and 8 deletions.
diff --git a/UANodeManager.cs b/UANodeManager.cs
@@ -1581,28 +1581,56 @@ private void HandleRockwellDataWrite(AssetTag tag, string assetId, string value)
             string[] addressParts = tag.Address.Split(['?', '&', '=']);
             byte[] tagBytes = null;
 
-            if (tag.Type == "Float")
+            if (tag.Type == "BOOL")
             {
-                tagBytes = BitConverter.GetBytes(float.Parse(value));
+                tagBytes = BitConverter.GetBytes(bool.Parse(value));
             }
-            else if (tag.Type == "Boolean")
+            else if (tag.Type == "SINT")
             {
-                tagBytes = BitConverter.GetBytes(bool.Parse(value));
+                tagBytes = BitConverter.GetBytes(char.Parse(value));
             }
-            else if (tag.Type == "Integer")
+            else if (tag.Type == "INT")
+            {
+                tagBytes = BitConverter.GetBytes(short.Parse(value));
+            }
+            else if (tag.Type == "DINT")
             {
                 tagBytes = BitConverter.GetBytes(int.Parse(value));
             }
-            else if (tag.Type == "String")
+            else if (tag.Type == "LINT")
             {
-                tagBytes = Encoding.UTF8.GetBytes(value);
+                tagBytes = BitConverter.GetBytes(Int64.Parse(value));
+            }
+            else if (tag.Type == "USINT")
+            {
+                tagBytes = BitConverter.GetBytes(char.Parse(value));
+            }
+            else if (tag.Type == "UINT")
+            {
+                tagBytes = BitConverter.GetBytes(ushort.Parse(value));
+            }
+            else if (tag.Type == "UDINT")
+            {
+                tagBytes = BitConverter.GetBytes(uint.Parse(value));
+            }
+            else if (tag.Type == "ULINT")
+            {
+                tagBytes = BitConverter.GetBytes(UInt64.Parse(value));
+            }
+            else if (tag.Type == "REAL")
+            {
+                tagBytes = BitConverter.GetBytes(float.Parse(value));
+            }
+            else if (tag.Type == "LREAL")
+            {
+                tagBytes = BitConverter.GetBytes(double.Parse(value));
             }
             else
             {
                 throw new ArgumentException("Type not supported by Rockwell.");
             }
 
-            _assets[assetId].Write(addressParts[0], 0, string.Empty, tagBytes, false).GetAwaiter().GetResult();
+            _assets[assetId].Write(addressParts[0], byte.Parse(addressParts[1]), tag.Type, tagBytes, false).GetAwaiter().GetResult();
         }
 
         private void HandleBeckhoffDataRead(AssetTag tag, string assetId)