Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add todo to remove conditional statement #7163

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Add todo to remove conditional statement #7163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cefa82c
mark generated by script as false when creating new domain
auumgn Dec 18, 2024
298497b
add todo to remove conditional statement
auumgn Dec 18, 2024
b722b19
Merge branch 'main' into mark-generated-by-script-as-false-when-creat…
auumgn Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions orcid-core/src/main/java/org/orcid/core/common/manager/impl/SummaryManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,9 +524,13 @@ public void generateEmailDomainsSummary(RecordSummary recordSummary, String orci
for (ProfileEmailDomainEntity ped : emailDomains) {
ed = new EmailDomain();
ed.setValue(ped.getEmailDomain());
if (!ped.getGeneratedByScript() && ped.getDateCreated() != null) {
VerificationDate verificationDate = new VerificationDate(DateUtils.convertToXMLGregorianCalendar(ped.getDateCreated()));
ed.setVerificationDate(verificationDate);
if (!ped.getGeneratedByScript()) {
//TODO: There is a bug where the date_created is null for some records, so, we need to add this one meanwhile we fix this card https://trello.com/c/qh1uioKO/9557-qa-verified-date-not-displayed-for-new-email-domains
//Remove this if statement once that card get to PROD
if(ped.getDateCreated() != null) {
VerificationDate verificationDate = new VerificationDate(DateUtils.convertToXMLGregorianCalendar(ped.getDateCreated()));
ed.setVerificationDate(verificationDate);
}
}
edList.add(ed);
}
Expand Down
Loading