New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-request-id replication #2

Merged

jagthedrummer merged 3 commits into Octo-Labs:master from jjb:x_request_id_replication

May 31, 2013

Contributor

jjb commented May 30, 2013

here's the functionality I proposed in discussion in #1 (along with some small code improvements)

jjb added 3 commits

May 30, 2013 17:10


          use rspec "subject"

fef7d28

also fix some whitespace and normalize/fix variable names


          check for the actual value of the header

f5efbfd


          optionally copy heroku-request-id into x-request-id

b62810c

* https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/middleware/request_id.rb
* http://guides.rubyonrails.org/3_2_release_notes.html#action-dispatch
* http://blog.rubyrockers.com/2011/10/x-request-id-tracking-taggedlogging-rails/

jagthedrummer merged commit b62810c into Octo-Labs:master

Member

jagthedrummer commented May 31, 2013

Thanks for the PR @jjb! Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet